Make unbounded a const function #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogti
reviewed
Apr 13, 2024
src/unbounded.rs
Outdated
| @@ -149,6 +149,22 @@ pub struct Unbounded<T> { | |||
|
|
|||
| impl<T> Unbounded<T> { | |||
| /// Creates a new unbounded queue. | |||
| #[cfg(not(loom))] | |||
There was a problem hiding this comment.
this sort of code duplication is very unfortunate, could we encapsulate that into a macro? (just the cfg + const switch)
There was a problem hiding this comment.
(Feel free to copy a helper macro used in my crates if needed)
taiki-e
reviewed
Apr 13, 2024
taiki-e
approved these changes
Apr 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
ConcurrentQueue::unboundeda const function. It'd be great ifboundedcould beconstas well, but this would likely require static memory allocation support in const functions, which is currently not allowed by the compiler. This would enable smol-rs/async-executor#112 to be directly constructable in a const context (i.e. static/thread_local variable initialization without OnceLock). It might also allow unboundedasync_channels to be constructed in a similar context.