Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the EventListener::new() footgun #94

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Fix the EventListener::new() footgun #94

merged 5 commits into from
Nov 15, 2023

Commits on Nov 15, 2023

  1. Fix the EventListener::new() footgun 

    This is a breaking change. It makes `new()` take no parameters in its
signature and `listen()` take a reference to an event in its signature.
This should avoid a footgun where a listener can be waited on without
listening on it.

Closes #91

Signed-off-by: John Nunley <dev@notgull.net>
    @notgull
    notgull committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e10eb26 View commit details
    Browse the repository at this point in the history

  2. Fix benchmark 

    Signed-off-by: John Nunley <dev@notgull.net>
    @notgull
    notgull committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    597903b View commit details
    Browse the repository at this point in the history

  3. Please clippy 

    Signed-off-by: John Nunley <dev@notgull.net>
    @notgull
    notgull committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    cda7be5 View commit details
    Browse the repository at this point in the history

  4. Please clippy again 

    Signed-off-by: John Nunley <dev@notgull.net>
    @notgull
    notgull committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    46e7c13 View commit details
    Browse the repository at this point in the history

  5. Move the Option<> over the event instead 

    Signed-off-by: John Nunley <dev@notgull.net>
    @notgull
    notgull committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    1911542 View commit details
    Browse the repository at this point in the history