-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#35 detailed error messages #37
Conversation
I added test coverage for the changes to I had specifically avoided using method names like |
this.parser.settings(URLParsingSettings.create().withErrorHandler(new ErrorHandler() { | ||
@Override | ||
public void error(GalimatiasParseException error) throws GalimatiasParseException { | ||
errorException = error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the error should be thrown so that parsing stops.
Implementation and tests are good. I'll add some further cases later. Could you address my comments and squash all changes to a single commit? |
Thank you @blicksky! I have merged this PR to a branch: https://github.com/smola/galimatias/tree/feature/issue-35 I will merge to master once I'm sure all cases are covered. |
No description provided.