Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken for default-features=false #2

Closed
phil-opp opened this issue Jan 22, 2017 · 2 comments
Closed

Build broken for default-features=false #2

phil-opp opened this issue Jan 22, 2017 · 2 comments

Comments

@phil-opp
Copy link
Contributor

Hi! First of all, thanks a lot for creating this library. It seems like a great fit for embedded and OS development.

Unfortunately, it no longer compiles with default-features=false, since
ManagedSlice::Owned is only available with use_std or use_collections.

error: no associated item named `Owned` found for type `managed::ManagedSlice<'_, _>` in the current scope
  --> /…/smoltcp-ebf9e93b1271bd34/874d192/src/socket/set.rs:64:13
   |
64 |             ManagedSlice::Owned(ref mut sockets) => {
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

(I think it would be a good idea to add an additional travis build config for default-features=false to prevent similar issues in the future.)

@whitequark
Copy link
Contributor

Fixed

@phil-opp
Copy link
Contributor Author

Thanks!

dlrobertson pushed a commit to dlrobertson/smoltcp that referenced this issue Dec 20, 2017
whitequark added a commit to astro/smoltcp that referenced this issue Mar 11, 2018
stabler added a commit to parallelsystems/smoltcp that referenced this issue Jun 10, 2021
…cp-rs#2)

[SW-102] expose dhcp state to be used directly by upstream code

* [SW-102] expose dhcp state to be used directly by upstream code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants