Adjusting TCP connection 3-way handshake state management #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test please? |
|
Test should now be added |
irwineffect
added a commit
to irwineffect/minimq
that referenced
this pull request
Oct 23, 2020
Previously, the device would not reconnect to MQTT broker after restarting the program due to smoltcp trying to reuse the previous TCP connection. This was fixed in smoltcp-rs/smoltcp#367, but this change has not been released on crates.io yet, so we are pulling in a specific version of smoltcp until this is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #366 by adding an
abort()if anACKis received without theSYNflag set when inSYN-SENT.The implications of this are that the user will have to re-
connectthe TCP socket after this occurrence.