Skip to content

Commit

Permalink
pushing fixes and requests by colleagues
Browse files Browse the repository at this point in the history
  • Loading branch information
certara-smouksassi committed Jan 28, 2024
1 parent fcd922a commit 4d54d57
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 14 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ License: MIT + file LICENSE
SystemRequirements: pandoc with https support
LazyData: true
VignetteBuilder: knitr
RoxygenNote: 7.3.0
RoxygenNote: 7.3.1
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
6 changes: 5 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# ggquickeda (development version)
# ggquickeda 0.3.1.9000

* added arguments `show.exptile_values`, `show.exptile_values_pos` and `show.exptile_values_order` to
`ggkmrisktable()` requested by Mathilde
* fixes for `gglogisticexpdist()` and `ggcontinuousexpdist()` when `exposure_distribution`and `exposure_metric_split` where set to "none"

# ggquickeda 0.3.1

Expand Down
10 changes: 5 additions & 5 deletions R/ggcontinuousexpdist.R
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ plogis <- function(x) exp(x)/(1+exp(x))
#' @param xlab text to be used as x axis label
#' @param ylab text to be used as y axis label
#' @param mean_text_size mean text size default to 5
#' @param mean_obs_bydose observed mean by dose TRUE/FALSE
#' @param N_text_size N respondents/Ntotal by exposure bin text size default to 5
#' @param mean_obs_bydose observed mean by dose `TRUE`/`FALSE`
#' @param N_text_size N by exposure bin text size default to 5
#' @param binlimits_text_size 5 binlimits text size
#' @param binlimits_ypos binlimits y position default to 0
#' @param binlimits_color binlimits text color default to "gray70"
Expand Down Expand Up @@ -167,9 +167,9 @@ ggcontinuousexpdist <- function(data = effICGI,
if(exposure_metric_split=="none") {
data.long <- data.long |>
dplyr::mutate(exptile = dplyr::case_when(
expvalue == exposure_metric_soc_value ~ NA,
expvalue == exposure_metric_plac_value ~ NA,
expvalue > exposure_metric_plac_value ~ expvalue))
expvalue == exposure_metric_soc_value ~ "SOC",
expvalue == exposure_metric_plac_value ~ "Placebo",
expvalue > exposure_metric_plac_value ~ "(all)"))
data.long$keynumeric <- - dist_position_scaler*as.numeric(forcats::fct_rev(as.factor(dplyr::pull(data.long[,DOSEinputvar])))) + dist_offset
xintercepts <- data.long|>
dplyr::group_by(expname,!!sym(endpointinputvar) )|>
Expand Down
8 changes: 4 additions & 4 deletions R/gglogisticexpdist.R
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ plogis <- function(x) exp(x)/(1+exp(x))
#' strip.background.y = element_blank())
#' library(patchwork)
#' (a | b ) +
#' plot_layout(guides = "collect")&
#' plot_layout(guides = "collect", axes = "collect_x")&
#' theme(legend.position = "top")
#'
#'}
Expand Down Expand Up @@ -253,9 +253,9 @@ gglogisticexpdist <- function(data = effICGI,
if(exposure_metric_split=="none") {
data.long <- data.long |>
dplyr::mutate(exptile = dplyr::case_when(
expvalue == exposure_metric_soc_value ~ NA,
expvalue == exposure_metric_plac_value ~ NA,
expvalue > exposure_metric_plac_value ~ expvalue))
expvalue == exposure_metric_soc_value ~ "SOC",
expvalue == exposure_metric_plac_value ~ "Placebo",
expvalue > exposure_metric_plac_value ~ "(all)"))
data.long$keynumeric <- - dist_position_scaler*as.numeric(forcats::fct_rev(as.factor(dplyr::pull(data.long[,DOSEinputvar])))) + dist_offset
xintercepts <- data.long|>
dplyr::group_by(expname,!!sym(endpointinputvar) )|>
Expand Down
4 changes: 2 additions & 2 deletions man/ggcontinuousexpdist.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/gglogisticexpdist.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4d54d57

Please sign in to comment.