Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: extension method "Abs" outputs malformed URLs #15

Merged
merged 1 commit into from
May 18, 2011
Merged

Fix: extension method "Abs" outputs malformed URLs #15

merged 1 commit into from
May 18, 2011

Conversation

jamestelfer
Copy link
Contributor

Use "AbsoluteUri" instead of "ToString()" to avoid removing the escaping from query string parameters.

This means that a URL like "/page.html?query=parameter%20value" will be output with the %20 intact, rather than using a space.

Thanks for the great package, a joy to use :)

@smsohan
Copy link
Owner

smsohan commented May 17, 2011

Thanks for pointing this to me. I will include this in the next release.


Sent from my iPhone

S M Sohan
Consultant
ThoughtWorks Canada
Suite 1100, 600 6th Ave SW
Calgary, AB T2P 0S5
Cell: +1 403 714 2673

On 2011-05-16, at 8:12 PM, jamestelfer
reply@reply.github.com
wrote:

Use "AbsoluteUri" instead of "ToString()" to avoid removing the escaping from query string parameters.

This means that a URL like "/page.html?query=parameter%20value" will be output with the %20 intact, rather than using a space.

Thanks for the great package, a joy to use :)

Reply to this email directly or view it on GitHub:
#15

@jamestelfer
Copy link
Contributor Author

jamestelfer commented May 17, 2011 via email

smsohan added a commit that referenced this pull request May 18, 2011
Fix: extension method "Abs" outputs malformed URLs
@smsohan smsohan merged commit c1059ff into smsohan:master May 18, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants