Added ability to specify Authenticator type on Android systems. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s you to specify STRONG (which should be fingerprint) and WEAK (which should be face), but it depends on the device.
|
What's blocking here? |
|
If you can get this merged that would be great 😄 |
|
I'm not working for this project unfortunately |
|
Hi. Is this project still active? Are there any plans to merge this PR? Thanks! |
|
We are using this as part of the net8 MAUI project and decided to update this project and release the new version as Open-Source: https://github.com/oscoreio/Maui.Biometric I'll be glad if you do a little review of the new code, because I was mostly inspired by your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a little rough around the edges as I'm not very confident with C# and Visual Studio.
Unfortunately I wasn't able to update MonoAndroid to a version that knows about Android API 30 :(
Allows you to specify STRONG (which should be fingerprint) and WEAK (which should be face), but it depends on the device.
This should fix #231 which in turn should allow BitWarden bitwarden/mobile#1902 (and other users) to specify the authenticator to use. And if the device has correctly configured fingerprint to be
STRONGand face unlock to beWEAKthen the app could select which authentication method to use.