Fix Can't call method 'notes' on unblessed reference in plugins/logging/file.

[salvis]

I still get a

FATAL PLUGIN ERROR [logging::file_3a7]: Can't call method "notes" on unblessed reference at /home/smtpd/qpsmtpd/plugins/logging/file line 279.

message from the current HEAD. This patch fixes it.

[coveralls]

Coverage remained the same at 48.84% when pulling bdc536e on salvis:master into e551786 on smtpd:master.

[salvis]

Thank you for committing this and making HEAD work for me. I continue to wonder why this seemingly happens only to me. Is it because I'm the only one running qpsmtpd from xinetd according to https://wiki.qpsmtpd.org/doku.php?id=deploy:start ?

If I enable logging/file with loglevel DEBUG, then hook_logging() is called 300+ times, and out of these 15 calls come in with a $transaction object that cannot do 'notes'. Why does this happen? And why only on my servers?

A side-effect of the fix above is that log_output() is called 15 times to re-evaluate the _log_format, and since I cannot use %i (see below) I have a timestamp with seconds in the _log_format. The seconds typically change during a transaction and each transaction is split into 3 or 4 DEBUG log files. (Transactions sometimes get interleaved, too.)

Since...

sub log_output {
my ($self, $transaction) = @_;
my $output = $self->{_log_format};
$output =~ s/%i/($transaction->notes('logging-session-id') || 'parent')/ge;
$output = strftime $output, localtime;
$output;
}

... also calls $transaction->notes(), if "%i" is in the _log_format, I cannot use "%i" or I get 15
FATAL PLUGIN ERROR [logging::file_3a7]: Can't call method "notes" on unblessed reference...
messages again. These are not actually fatal though, but "%i" gets replaced with "parent", which is useless.

With xinetd, the logging-session-id seems to be $$ (the pid). Is it different in other configurations? If there was a way to tell in which configuration we're running, I could use the $$, save the file name and enforce "nosplit" in the xinetd case.

What do you think?

[msimerson]

No idea, I no longer have any QP deployments.

[salvis]

Ouch, sorry to hear that...