Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

have a private _compat module to not depend on a specifc flask version #64

Closed
wants to merge 1 commit into from
Closed

Conversation

ThomasWaldmann
Copy link
Contributor

No description provided.

@ThomasWaldmann
Copy link
Contributor Author

now that we have py3 compatible pocoo stuff released, could someone please check what's the problem with this, so that we can also have a py3 compatible flask-script release soon?

@techniq
Copy link
Collaborator

techniq commented Jul 30, 2013

Sorry for the lack of updates, I've been busy with work and other personal projects. There is still 1 failing test in Python 3.3 in the python3 branch that needs to be resolved. I have some changes locally I haven't pushed yet. I've spent a few evenings attempting to fix this but haven't yet (there appears to be some difference with python 3.x vs 2.x with argparse and parser.set_default, but that is just my guess at this point. I'll try to revisit this hopefully tonight and at least share my current changes in case someone else can take a stab at it.

I haven't merged in your PR yet as I wanted to get a working build on all platforms first.

@ThomasWaldmann
Copy link
Contributor Author

Ah, right, now I remember...

Yeah, I tried also to fix that, but couldn't quickly find the root cause of that remaining issue.

But, just as a suggestion: as long as there is no issue on python 2.x platforms, you could merge it without regression. Of course, before officially announcing/releasing 3.3 support, it has to get fixed.

@techniq
Copy link
Collaborator

techniq commented Jul 30, 2013

True. I wouldn't like to get the python3 branch merged even without python 3.3 support just to get more people looking at it. There is also an open issue (#63) that is fixed but needs a release to PyPI. I'll look at least getting everything ready for a 2.x release and hopefully get 3.x fixed soon.

@techniq
Copy link
Collaborator

techniq commented Aug 7, 2013

Manually merged - 0df2124

@techniq techniq closed this Aug 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants