This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Allow exception to bubble up naturally during Shell make_context callback #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techniq
added a commit
that referenced
this pull request
Aug 13, 2013
Allow exception to bubble up naturally during Shell make_context callback
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an exception occurs during the make_context function passed to Shell, it is just being caught and re-raises the exception object, which loses the original stack trace of the exception. These two lines should just be removed completely, as any exception that is cannot be handled should just be allowed to bubble up naturally.