Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Allow exception to bubble up naturally during Shell make_context callback #72

Merged
merged 1 commit into from

2 participants

@bendavis78

Currently if an exception occurs during the make_context function passed to Shell, it is just being caught and re-raises the exception object, which loses the original stack trace of the exception. These two lines should just be removed completely, as any exception that is cannot be handled should just be allowed to bubble up naturally.

@techniq techniq merged commit f26b0ca into smurfix:master
@techniq
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 2 deletions.
  1. +0 −2  flask_script/__init__.py
View
2  flask_script/__init__.py
@@ -362,7 +362,5 @@ def run(self, commands=None, default_command=None):
result = self.handle(sys.argv[0], sys.argv[1:])
except SystemExit as e:
result = e.code
- except Exception as e:
- raise e
sys.exit(result or 0)
Something went wrong with that request. Please try again.