Allow exception to bubble up naturally during Shell make_context callback #72

Merged
merged 1 commit into from Aug 13, 2013

Conversation

Projects
None yet
2 participants
Contributor

bendavis78 commented Aug 13, 2013

Currently if an exception occurs during the make_context function passed to Shell, it is just being caught and re-raises the exception object, which loses the original stack trace of the exception. These two lines should just be removed completely, as any exception that is cannot be handled should just be allowed to bubble up naturally.

@techniq techniq added a commit that referenced this pull request Aug 13, 2013

@techniq techniq Merge pull request #72 from bendavis78/master
Allow exception to bubble up naturally during Shell make_context callback
f26b0ca

@techniq techniq merged commit f26b0ca into smurfix:master Aug 13, 2013

1 check passed

default The Travis CI build passed
Details
Collaborator

techniq commented Aug 13, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment