Update to supported version #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to returning QObject* in calls to C++ objects from QML (e.g. getItem(i)), those objects were changing ownership to QML and were subject to gc. That could've been noticed during switching between journey results and journey details results (instantly switch back and forth to create enough garbage). `var item = result.getItem(i);` `item` would be null after some time. So it was ending up in page showing loader and not doing anything or in a bit more rare cases with segfault.
Due to returning QObject* in calls to C++ objects from QML (e.g. getItem(i)), those objects were changing ownership to QML and were subject to gc. That could've been noticed during switching between journey results and journey details results (instantly switch back and forth to create enough garbage). `var item = result.getItem(i);` `item` would be null after some time. So it was ending up in page showing loader and not doing anything or in a bit more rare cases with segfault.
add london parser (TFL)
add namespace TransportModes
…moved) make it work with 'clickable --desktop' by changing the build folders
change qml page headers for ubuntu (Ubuntu.Components 1.3 warnings re…
…412b/fahrplan into 412b-qt-qml-fixing-ownership-rebased
…ml-fixing-ownership-rebased
…tion to london parser
412b qt qml fixing ownership rebased
…edits tab (Ubuntu Touch)
Change layout height to make full text visible on the About page's …
Closed
poetaster
added a commit
to poetaster/fahrplan
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the packager for UbuntuTouch this is the currently releases version which is actively supported.
Most of the work is from Chris Clime.
It would seem sensible to merge this into you reference implementation so other platforms can make use of all this work.