Skip to content
This repository has been archived by the owner on Feb 17, 2024. It is now read-only.

gcc 8 #25

Closed
wants to merge 1 commit into from
Closed

gcc 8 #25

wants to merge 1 commit into from

Conversation

Neo2SHYAlien
Copy link
Contributor

Add support for gcc version 8.
Signed-off-by: Neo2SHYAlien neo2shyalien@gmail.com

Add support for gcc version 8.
Signed-off-by: Neo2SHYAlien <neo2shyalien@gmail.com>
@smxi
Copy link
Owner

smxi commented Aug 6, 2018

Please note, this actually required more changes than this, and also, based on the fact gcc now appears to have fallen into the rapid major version inflation game that firefox and chrome have made popular, I committed a fix that future proofs up to 2 major version digits, which based on the silly pattern we see from chrome and firefox, should cover us for a few years ;)

Thanks for noticing this, I'm not merging this pull but check the new version for the full fix. Note that I gave up on trying to do specific version tests, and now simply look for a valid number in the format xx.yy or x.yy or xx.y


grep -Eio 'gcc[[:space:]]*version[[:space:]]*[0-9]{1,2}\.[0-9]{1,2}' /proc/version | grep -Eo '[0-9]{1,2}\.[0-9]{1,2}'
7.3

Note that this fix would continue to work when gcc hits version 10.xx

@smxi smxi closed this Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants