Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] File with "Printer absolute correction" other than zero won't open #4

Closed
b-fitzpatrick opened this issue Jun 25, 2020 · 7 comments
Closed

[BUG] File with "Printer absolute correction" other than zero won't open #4

b-fitzpatrick opened this issue Jun 25, 2020 · 7 comments
Assignees
@sn4k3
Labels
bug Something isn't working

Comments

@b-fitzpatrick
Copy link

Describe the bug
When attempting to load a file from PrusaSlicer where the "Printer absolute correction" setting is not zero, it never loads. The "Loading..." dialog just keeps waiting.

To Reproduce
Steps to reproduce the behavior:

  1. On the "Printer Settings" tab of PrusaSlicer, set "Printer absolute correction:" to -0.05.
  2. Slice and export.
  3. Open the exported file with UVtools
  4. It never opens.

Expected behavior
I expect the file to open and for the correction to be applied.

Desktop (please complete the following information):

  • OS: Windows 10 Pro v1803

I want to decrease the size of walls, similar to "Erode" in UVtools, but I would like to do so by a small amount to calibrate the parts from the printer. For example, I printed a 10mm x 10 mm open-ended box with 1 mm walls. The walls measure around 1.1 mm thick, and the box width measures around 10.1 mm.

Looking at the .png files in the .sl1 output file, it appears that "Printer absolute correction" is working as expected.

In "SL1File.cs", variable "AbsoluteCorrection" is typed as a byte, but it should probably be a float. I confirmed that setting "Printer absolute correction" to 1 in PrusaSlicer allows the file to open, and the layer images are inflated by 1 mm.
@sn4k3
Copy link
Owner

sn4k3 commented Jun 25, 2020 •
edited

You are right, byte value will trigger error when try to parse a float.
Will be fixed on next release.
Meanwhile you can do the same on UVtools. Use Resize function and resize by 99.95%
Or if you want i can give you the last dev with that fixed

@b-fitzpatrick
Copy link
Author

Thanks. I don't think resize is the same thing. I need to remove 0.05 mm from each outside surface, similar to "Erode" in UVtools.

In the meantime, I'll just edit the prusaslicer.ini file, since it doesn't seem like that value is used for anything. FYI, the same issue exists with GammaCorrection.

@sn4k3
Copy link
Owner

sn4k3 commented Jun 25, 2020

After slice that value is just informative, you can't change .ini and expect that will print with correction.
Here the v0.6 beta with that fixed: https://easyupload.io/vk0hvz
Try and report back.
I fixed a bunch of bytes to floats, inc GammaCorrection

@sn4k3 sn4k3 added the bug Something isn't working label Jun 25, 2020
@b-fitzpatrick
Copy link
Author

I've confirmed that the fix works. Thanks.
FYI, I was changing the .ini file that's contained inside the .sl1 file, to avoid the bug. The corrections were already made during slicing, so the print was correct.

@sn4k3
Copy link
Owner

sn4k3 commented Jun 28, 2020

Can you give the Bene specs so i can add it?

@b-fitzpatrick
Copy link
Author

I don't know anything about Bene specs. I'm guessing this comment was intended for the other open issue.

@sn4k3
Copy link
Owner

sn4k3 commented Jun 28, 2020

You are right, sorry for confusion

sn4k3 added a commit that referenced this issue Jun 29, 2020
@sn4k3
v0.6.0.0
2cbb3f3 
* (Add) UVtools now notify when a new version available is detected
* (Add) Mutator "Flip"
* (Add) Mutator "Rotate"
* (Add) User Settings - Many parameters can now be customized to needs
* (Add) File load elapsed time into Title bar
* (Add) Outline - Print Volume bounds
* (Add) Outline - Layer bounds
* (Add) Outline - Hollow areas
* (Add) Double click layer picture to Zoom To Fit
* (Improvement) Huge performance boost in layer reparing and in every mutator
* (Improvement) Layer preview is now faster
* (Improvement) Islands detection is now better and don't skip any pixel, more islands will show or the region will be bigger
* (Improvement) Islands search are now faster, it will jump from island to insland instead of search in every pixel by pixel
* (Improvement) ResinTrap detection and corrected some cases where it can't detect a drain
* (Improvement) Better memory optimization by dispose all objects on operations
* (Improvement) Image engine changed to use only OpenCV Mat instead of two and avoid converting from one to another, as result there's a huge performance gain in some operations (#6)
* (Improvement) UVtools now rely on UVtools.Core, and drop the UVtools.Parser. The Core now perform all operations and transformations inplace of the GUI
* (Improvement) If error occur during save it will show a message with the error
* (Improvement) When rotate layer it will zoom to fit
* (Improvement) Allow zoom to fit to print volume area instead of whole build volume
* (Removed) ImageSharp dependency
* (Removed) UVtools.Parser project
* (Fix) Nova3D Elfin printer values changed to Display Width : 131mm / Height : 73mm & Screen X: 2531 / Y: 1410 (#5)
* (Fix) Fade resizes make image offset a pixel from layer to layer because of integer placement, now it matain the correct position
* (Fix) sl1: AbsoluteCorrection, GammaCorrection, MinExposureTime, MaxExposureTime, FastTiltTime, SlowTiltTime and AreaFill was byte and float values prevents the file from open (#4)
* (Fix) zcodex: XCorrection and YCorrection was byte and float values prevents the file from open (#4)
* (Fix) cws: XCorrection and YCorrection was byte and float values prevents the file from open (#4)
* (Fix) cws: Wrong # char on .gcode file prevent from printing (#4)
@sn4k3 sn4k3 closed this as completed Jun 29, 2020
@trohnjavolta trohnjavolta mentioned this issue Mar 18, 2021
Closed
@orosalsero1 orosalsero1 mentioned this issue Apr 4, 2022
Closed
@mjf55 mjf55 mentioned this issue Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sn4k3 sn4k3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sn4k3 @b-fitzpatrick