Skip to content

Commit

Permalink
Adapt counters to new IPv4 reassembly table size
Browse files Browse the repository at this point in the history
Also prevent lwcounter from creating counters that are now managed
directly by the reassembly app.
  • Loading branch information
wingo committed Aug 16, 2017
1 parent 366d3b8 commit 707c1e7
Show file tree
Hide file tree
Showing 53 changed files with 60 additions and 53 deletions.
9 changes: 8 additions & 1 deletion src/apps/lwaftr/lwcounter.lua
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,17 @@ function read_counters (pid)
return ret
end

-- Temporary hack until we migrate all of the lwAFTR's apps to use the
-- SHM frame mechanism.
local ipv4_reassemble = require('apps.ipv4.reassemble')
function init_counters ()
local counters = {}
for k, id in pairs(counter_names()) do
counters[k] = {counter}
if ipv4_reassemble.Reassembler.shm[k] then
-- Don't create this counter; IPv4 reassemble app handles it.
else
counters[k] = {counter}
end
end
return shm.create_frame(counters_dir, counters)
end
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
return {
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-frag-not"] = 1,
}
2 changes: 1 addition & 1 deletion src/program/lwaftr/tests/data/counters/empty.lua
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
return {
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ return {
["in-ipv4-bytes"] = 1494,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-icmpv4-bytes"] = 590,
["out-icmpv4-packets"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ return {
["in-ipv4-bytes"] = 1494,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ return {
["in-ipv6-bytes"] = 6784,
["in-ipv6-frag-reassembly-unneeded"] = 64,
["in-ipv6-packets"] = 64,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 6784,
["out-ipv6-frag-not"] = 64,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ return {
["in-ipv6-bytes"] = 106,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 106,
["out-ipv6-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ return {
["in-ipv6-bytes"] = 138,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ return {
["in-ipv6-bytes"] = 138,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 138,
["out-ipv6-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
return {
["in-ipv6-frag-reassembly-unneeded"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-frag-not"] = 1,
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ return {
["in-ipv4-frag-needs-reassembly"] = 3,
["in-ipv4-frag-reassembled"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 1514,
["out-ipv6-frag"] = 2,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
return {
["in-ipv4-frag-reassembly-unneeded"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ return {
["in-ipv4-bytes"] = 66,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-icmpv4-bytes"] = 94,
["out-icmpv4-packets"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 66,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 106,
["out-ipv6-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ return {
["in-ipv4-frag-needs-reassembly"] = 3,
["in-ipv4-frag-reassembled"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 1500,
["out-ipv6-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 1494,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 1534,
["out-ipv6-frag"] = 2,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 2734,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 2774,
["out-ipv6-frag"] = 3,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 1474,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 1514,
["out-ipv6-frag"] = 2,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 1474,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 1514,
["out-ipv6-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 98,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 138,
["out-ipv6-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 70,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-bytes"] = 110,
["out-ipv6-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv4-bytes"] = 66,
["in-ipv4-frag-reassembly-unneeded"] = 2,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-frag-not"] = 1,
["out-ipv6-bytes"] = 106,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ return {
["in-ipv4-bytes"] = 66,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ return {
["in-ipv4-bytes"] = 98,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ return {
["in-ipv4-bytes"] = 98,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ return {
["in-ipv4-bytes"] = 98,
["in-ipv4-frag-reassembly-unneeded"] = 1,
["in-ipv4-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv6-bytes"] = 154,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-icmpv4-bytes"] = 94,
["out-icmpv4-packets"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ return {
["in-ipv6-bytes"] = 106,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-icmpv6-bytes"] = 154,
["out-icmpv6-packets"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ return {
["in-ipv6-bytes"] = 138,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-icmpv6-bytes"] = 186,
["out-icmpv6-packets"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv6-bytes"] = 1046,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 1006,
["out-ipv4-frag"] = 2,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv6-bytes"] = 1500,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 1460,
["out-ipv4-frag"] = 3,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ return {
["in-ipv6-frag-needs-reassembly"] = 2,
["in-ipv6-frag-reassembled"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 1494,
["out-ipv4-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv6-bytes"] = 106,
["in-ipv6-frag-reassembly-unneeded"] = 2,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 66,
["out-ipv4-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv6-bytes"] = 106,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 66,
["out-ipv4-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ return {
["in-ipv6-frag-needs-reassembly"] = 2,
["in-ipv6-frag-reassembled"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 1474,
["out-ipv4-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ return {
["in-ipv6-frag-needs-reassembly"] = 2,
["in-ipv6-frag-reassembled"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 1474,
["out-ipv4-frag"] = 3,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ return {
["in-ipv6-bytes"] = 154,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-icmpv4-bytes"] = 94,
["out-icmpv4-packets"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ return {
["in-ipv6-bytes"] = 106,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ return {
["in-ipv6-bytes"] = 154,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ return {
["in-ipv6-bytes"] = 106,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ return {
["in-ipv6-bytes"] = 106,
["in-ipv6-frag-reassembly-unneeded"] = 1,
["in-ipv6-packets"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-icmpv4-bytes"] = 94,
["out-icmpv4-packets"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ return {
["in-ipv6-bytes"] = 212,
["in-ipv6-frag-reassembly-unneeded"] = 2,
["in-ipv6-packets"] = 2,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 66,
["out-ipv4-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ return {
["in-ipv6-bytes"] = 212,
["in-ipv6-frag-reassembly-unneeded"] = 3,
["in-ipv6-packets"] = 2,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv4-bytes"] = 66,
["out-ipv4-frag-not"] = 1,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
return {
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
["out-ipv6-frag-not"] = 1,
}
2 changes: 1 addition & 1 deletion src/program/lwaftr/tests/data/counters/ndp-secondary.lua
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
return {
["in-ipv6-frag-reassembly-unneeded"] = 1,
["memuse-ipv4-frag-reassembly-buffer"] = 463571780,
["memuse-ipv4-frag-reassembly-buffer"] = 463482888,
["memuse-ipv6-frag-reassembly-buffer"] = 464727376,
}
Loading

0 comments on commit 707c1e7

Please sign in to comment.