Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snabbwall tests make temporary files but do not delete them #1134

Open
wingo opened this issue Apr 28, 2017 · 1 comment
Open

snabbwall tests make temporary files but do not delete them #1134

wingo opened this issue Apr 28, 2017 · 1 comment

Comments

@wingo
Copy link
Contributor

wingo commented Apr 28, 2017

@eugeneia noted this bug. Perhaps he can provide more details if he has them handy. To fix!
@eugeneia
Copy link
Member

A temporary file is created here via mktemp but never deleted:

snabb/src/program/wall/tests/filter-pcaps.test

Line 16 in 42e2940

output=`mktemp`

takikawa referenced this issue in Igalia/snabb Aug 7, 2017
@takikawa
Refactor snabbwall test script, remove temp files
7eaf4aa 
Fixes issue #1134
@takikawa takikawa mentioned this issue Aug 7, 2017
Merged
dpino pushed a commit to dpino/snabb that referenced this issue Aug 29, 2017
@takikawa @dpino
Refactor snabbwall test script, remove temp files
68f7f86 
Fixes issue snabbco#1134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wingo @eugeneia