YANG model for current SnabbNFV configuration #911
Conversation
| range "0..max"; | ||
| } | ||
|
|
||
| description "Gigabytes per second."; |
There was a problem hiding this comment.
This will be interpreted as Gigabits per second and not bytes. Why not use bps ?
typedef bps {
type uint64;
unit "bps";
description "bits per second";
}
There was a problem hiding this comment.
Good catch, it should indeed say Gigabits.
|
This spec reflects the reality of SnabbNFV (literally a one-to-one translation from the API) and I would like to keep it that way. E.g. the (completely legitimate) issues pointed out here (except for my bits/bytes blunder) are really bugs in SnabbNFV imho. This is a first win for YANG as it showcased the bad configuration of SnabbNFV. I will continue by fixing these issues in SnabbNFV and update the YANG spec accordingly, probably all in this PR since it tracks the bugs nicely. |
|
Ok, understood :) FYI, YANG is very strict when it comes to making modifications between revisions so for example you can't rename a leaf if you are to follow the rules. We might want to discuss how to deal with versioning (simple way is to put version in the name, like my-model-v1.yang). |
|
I guess we should mark this PR as WIP and only merge a YANG spec once we are satisfied with it / SnabbNFV has a reasonable configuration API. |
eugeneia
changed the title
…re sophisticated approach without duplicating packets/copying data in the normal (non-resync) code paths
…old, replayed packets
…preliminary defaults; document it.
- move all resync logic into resync method - use self.aes_128_gcm.auth_buf for packet regeneration - remember to free temporary packet used in resync - move auditing code into audit method - make auditing configurable as specified in RFC 4303 - only log audits for packets that were actually rejected - update docs and comments
eugeneia
force-pushed
the
snabbnfv-traffic-yang
branch
from
4ed4e94
to
9c4a4d1
Compare
pairs instead. lib.ipsec: get rid of confusing “keymat” term.
eugeneia
changed the title
Start worker processes from leader
Initial YANG model for
program.snabbnfv.nfvconfig. The namespace is imaginary obviously.Cc @lukego