Various statistics counters for NFV apps #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the shared memory path (shm.path) to a private namespace for each app with prefix "app/$name". This means that apps can create shm objects such as counters and by default these will appear in a local namespace for that app.
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
# Conflicts: # src/core/app.lua
…eric representation.
option and support injecting a function to determine the current time.
This reverts commit 8bb3215.
# Conflicts: # src/core/counter.lua
This reverts commit 924ff4e.
This reverts commit e9f5dda.
# Conflicts: # src/apps/intel/intel10g.lua # src/core/app.lua
|
Both dependencies have been merged into next, but not via the same upstream branch. Any thoughts on the most reasonable way to proceed on this patch set short of waiting for an extra release, @lukego ? |
|
@kbara You could merge |
|
Good idea; I've done so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #931 #949
This adds statistics/diagnostics counters for various NFV apps.
rxerrorsbroken down into whyrxerrors(not insanely useful, can most of the time be inferred from link statistics)status(initially link down, link up once neighbor established),rxerrors(erroneous packets from south dropped, boken down into why),txerrors(erroneous packets from north), andtxdrop(packets from north dropped while link down)rxerrorsandsessions_establishedtxdrop(again, not insanely useful)If the recurring boilerplate code wasn't obvious until now, this PR shows it pretty prominently. My next step will be to abstract away the boilerplate I added in my recent PRs... :-)