Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rm unimplemented unmounting by 2nd arg null #539

Merged
merged 1 commit into from Jan 22, 2020
Merged

docs: rm unimplemented unmounting by 2nd arg null #539

merged 1 commit into from Jan 22, 2020

Conversation

mightyiam
Copy link
Contributor

Fixes #461.

mightyiam
mightyiam commented Jan 13, 2020
View reviewed changes
Copy link
Contributor Author

@mightyiam mightyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. 🆗

@mightyiam mightyiam requested a review from nojvek January 13, 2020 07:02
@mightyiam
Copy link
Contributor Author

@mreinstein how do you feel about this, please?

@mreinstein
Copy link
Contributor

Looks good to me! Thanks for the opportunity for input, and for the fix!

@mightyiam mightyiam merged commit 97a8d50 into master Jan 22, 2020
@mightyiam mightyiam deleted the unmount-documentation branch January 22, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojvek nojvek Awaiting requested review from nojvek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unmounting by patch(vnode, null) documented but not implemented
2 participants
@mightyiam @mreinstein