fix: make get_snakefile return rel path to snakefile #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cademirch
changed the title
|
@cademirch this isn't your fault: Let me make a fork for you to PR to, we will merge there and then PR with that fork. We probably need to figure out a means for this to work in the future, but right now that PR will be the point where we can evaluate the code isn't being malicious, etc. |
|
Change the PR to be against this branch: https://github.com/snakemake/snakemake-executor-plugin-googlebatch/tree/fix-snakefile-path |
|
oh looks like I can do it! |
|
Yeah I figured it wasn't me :) thanks! |
vsoch
added a commit
that referenced
this pull request
Apr 6, 2024
vsoch
pushed a commit
that referenced
this pull request
Apr 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.3](v0.3.2...v0.3.3) (2024-04-06) ### Bug Fixes * make get_snakefile return rel path to snakefile ([#40](#40)) ([#41](#41)) ([de2b1da](de2b1da)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #39.