-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting ntasks for non-MPI jobs #40
Comments
Can you please run a minimal example with the Suggestion for a minimal Snakefile:
|
I've attached the output using the minimal snakefile you suggested. This is the command line that I used: |
Thank you. This is really weird, because the SLURM docs state, that:
Which means that no requirement is imposed to set It will not hurt to implement submitting with a default 1 for the tasks and not requiring users with a situation like yours to patch the plugin. But I wonder: Are you in contact with your admins and can tell us why this cluster deviates from the SLURM defaults? |
related to #40 , ought to fix this. Does not hurt the smp nor the mpi case.
🤖 I have created a release *beep* *boop* --- ## [0.4.1](v0.4.0...v0.4.1) (2024-02-29) ### Bug Fixes * fixes issue [#40](#40) - ntasks set explicitly ([#44](#44)) ([f5c2c2c](f5c2c2c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@tatumdmortimer please update to the latest release and give it a try. |
I updated to the latest release, and the minimal Snakefile completed successfully. Thanks for fixing this so quickly. I did get in touch with the research computing at my university, and while they did confirm that cluster deviates from the defaults, they didn't provide me with a reason why. |
Well, then I am just glad it's working for you (and hope for anybody else, too). FYI: SchedMD's (the company behind SLURM) "ecosystem" shows some odd flowers, mainly due to service policies. I am merely trying to get information about the how and why of deviations from the standard to improve and stabilize these plugins. And sometimes the answer is "just because". Anyway, thanks for asking! |
I am working on transitioning my snakemake workflows to Snakemake v8. However, when I use this plugin with a profile, I get the following error message:
WorkflowError: SLURM job submission failed. The error message was sbatch: error: You must specify a number of tasks. sbatch: error: Batch job submission failed: Job size specification needs to be provided
Here are the versions of Snakemake, this plugin, and slurm that I am working with:
Here is my profile:
I cloned the repository, removed the
if job.resources.get("mpi", False):
on line 107 of__init__.py
, and reinstalled the plugin. This seems to have fixed the issue for me. Is there a reason these were only included in the sbatch command for mpi jobs?Thanks!
The text was updated successfully, but these errors were encountered: