Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force sacct to look at the last 2 days #9

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

fgvieira
Copy link
Contributor

@fgvieira fgvieira commented Dec 14, 2023

Possible fix to snakemake/snakemake#1227.

How often does the rate limiter checks sacct?

@fgvieira fgvieira changed the title Force sacct to look at the last 4 weeks Force sacct to look at the last 2 days Dec 14, 2023
@fgvieira fgvieira changed the title Force sacct to look at the last 2 days fix: Force sacct to look at the last 2 days Dec 14, 2023
@cmeesters cmeesters self-requested a review January 4, 2024 17:24
Copy link
Member

@cmeesters cmeesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay, seems working

Just: Do not know whether a multitude of checks with 2d look back time might put some strain on some slurmdbds . This remains to be observed.

@fgvieira
Copy link
Contributor Author

fgvieira commented Jan 4, 2024

We can also change it to 1 day, instead of 2.

@cmeesters
Copy link
Member

na, I'm fine with it. Just saying we need to pay a bit of attention, if there is any such feedback - ultimately, the user can limit the lookup rate, too.

@cmeesters cmeesters merged commit 914265d into snakemake:main Jan 5, 2024
4 checks passed
@fgvieira fgvieira deleted the sacct_starttime branch January 5, 2024 15:10
cmeesters pushed a commit that referenced this pull request Jan 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.5](v0.1.4...v0.1.5)
(2024-01-05)


### Bug Fixes

* Force sacct to look at the last 2 days
([#9](#9))
([914265d](914265d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants