Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Add a simple custom 404 page #85

Closed
wants to merge 3 commits into from
Closed

Conversation

R4356th
Copy link
Contributor

@R4356th R4356th commented Jun 20, 2020

Resolves

Moves a step forward in resolving #67.

Changes

Adds a very simple (and definitely non-impressive) custom 404 page, but should be enough for now, I guess.

Test Coverage

A live sample can be found here.

@Daniel4-Scratch
Copy link

don't you need a file to redirect to the 404 tmp? Like a YAML file.

@R4356th
Copy link
Contributor Author

R4356th commented Oct 4, 2020

Snap! devs will have to take care of that.

@Daniel4-Scratch
Copy link

Ok. Cause they could try yaml, but I’ll think it will bug out because the way the website works.

---
permalink: /404.html
---

@GrahamSH-LLK
Copy link

Ok. Cause they could try yaml, but I’ll think it will bug out because the way the website works.

---
permalink: /404.html
---

Uh, yeah! It doesn't work that way... This would require backend work on snap-cloud.

@Daniel4-Scratch
Copy link

Does that explain why Snap! didn't have a 404 page in the first time?

@cycomachead
Copy link
Member

We're going to move to a new system soon, so I'll close this. Thanks, though!

@cycomachead cycomachead closed this Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants