Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: add missing dosfstools to get fsck.fat #139

Merged
merged 1 commit into from Sep 11, 2019
Merged

hooks: add missing dosfstools to get fsck.fat #139

merged 1 commit into from Sep 11, 2019

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Sep 10, 2019

This should also get a spread test later in core where we corrupt the /boot fat system and double check that it get fscked/repaired.

sil2100
sil2100 approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful thing to have. +1

@sil2100 sil2100 merged commit c242649 into snapcore:master Sep 11, 2019
@xnox
Copy link
Contributor

xnox commented Apr 14, 2020

@mvo5 @sil2100 this change landed in core18, without landing on core20 first. Meaning this has regressed UC20 w.r.t. UC18.

Please stop landing PRs without a matching one for UC20

@anonymouse64 anonymouse64 mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sil2100 sil2100 sil2100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvo5 @xnox @sil2100