Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #10

Closed
wants to merge 1 commit into from
Closed

Update README.md #10

wants to merge 1 commit into from

Conversation

chipaca
Copy link
Contributor

@chipaca chipaca commented Oct 27, 2015

No description provided.

come-maiz
come-maiz reviewed Oct 27, 2015
View reviewed changes
README.md
cd ~/work/src/github.com/ubuntu-core/snappy
git checkout -b my-work
[hack on mywork]
git push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand git yet, but I think this should be:
git push --set-upstream origin my-work

@chipaca chipaca closed this Oct 28, 2015
@chipaca chipaca deleted the readme-fix branch October 28, 2015 13:13
bboozzoo added a commit to bboozzoo/snapd that referenced this pull request Mar 22, 2018
@bboozzoo
cmd/snap-confine: nvidia: add tls/libnvidia-tls.so* glob
91af9ce 
Make sure that we pick up nvidia TLS libs otherwise applications using libGLX
will fail in most mysterious ways.

The problem was debugged in detail in this forum topic [1].

A simple test case using glxinfo would segfault both inside the snap mount namespace
and in chroot, the backtrace pointing back to pthread_mutex_lock():

   (gdb) bt
   #0  0x00007ffff7559fb4 in pthread_mutex_lock () from target:/lib/x86_64-linux-gnu/libc.so.6
   #1  0x00007ffff6f5eddb in mt_mutex_lock (mutex=0x7ffff71e5180 <dispatchLock>) at glvnd_pthread.c:317
   #2  0x00007ffff6f23f77 in LockDispatch () at GLdispatch.c:144
   #3  0x00007ffff6f24115 in __glDispatchNewVendorID () at GLdispatch.c:198
   #4  0x00007ffff7212607 in __glXLookupVendorByName (vendorName=0x60d160 "nvidia") at libglxmapping.c:442
   #5  0x00007ffff7213811 in __glXLookupVendorByScreen (dpy=0x60aab0, screen=0) at libglxmapping.c:574
   #6  0x00007ffff7213966 in __glXGetDynDispatch (dpy=0x60aab0, screen=0) at libglxmapping.c:608
   #7  0x00007ffff7209563 in glXChooseVisual (dpy=0x60aab0, screen=0, attrib_list=0x609200) at libglx.c:215
   snapcore#8  0x00007ffff7b89d58 in glXChooseVisual (dpy=0x60aab0, screen=0, attribList=0x609200) at g_libglglxwrapper.c:183
   snapcore#9  0x0000000000401741 in ?? ()
   snapcore#10 0x00007ffff7465830 in __libc_start_main () from target:/lib/x86_64-linux-gnu/libc.so.6
   snapcore#11 0x0000000000401ea9 in ?? ()

Further debugging revealed that this may be related to libc/pthread & TLS handling.

[1]. https://forum.snapcraft.io/t/nvidia-acceleration-on-chrome-and-firefox/4532/

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
mvo5 pushed a commit that referenced this pull request Mar 22, 2018
@bboozzoo @mvo5
cmd/snap-confine: nvidia: add tls/libnvidia-tls.so* glob
544f92d 
Make sure that we pick up nvidia TLS libs otherwise applications using libGLX
will fail in most mysterious ways.

The problem was debugged in detail in this forum topic [1].

A simple test case using glxinfo would segfault both inside the snap mount namespace
and in chroot, the backtrace pointing back to pthread_mutex_lock():

   (gdb) bt
   #0  0x00007ffff7559fb4 in pthread_mutex_lock () from target:/lib/x86_64-linux-gnu/libc.so.6
   #1  0x00007ffff6f5eddb in mt_mutex_lock (mutex=0x7ffff71e5180 <dispatchLock>) at glvnd_pthread.c:317
   #2  0x00007ffff6f23f77 in LockDispatch () at GLdispatch.c:144
   #3  0x00007ffff6f24115 in __glDispatchNewVendorID () at GLdispatch.c:198
   #4  0x00007ffff7212607 in __glXLookupVendorByName (vendorName=0x60d160 "nvidia") at libglxmapping.c:442
   #5  0x00007ffff7213811 in __glXLookupVendorByScreen (dpy=0x60aab0, screen=0) at libglxmapping.c:574
   #6  0x00007ffff7213966 in __glXGetDynDispatch (dpy=0x60aab0, screen=0) at libglxmapping.c:608
   #7  0x00007ffff7209563 in glXChooseVisual (dpy=0x60aab0, screen=0, attrib_list=0x609200) at libglx.c:215
   #8  0x00007ffff7b89d58 in glXChooseVisual (dpy=0x60aab0, screen=0, attribList=0x609200) at g_libglglxwrapper.c:183
   #9  0x0000000000401741 in ?? ()
   #10 0x00007ffff7465830 in __libc_start_main () from target:/lib/x86_64-linux-gnu/libc.so.6
   #11 0x0000000000401ea9 in ?? ()

Further debugging revealed that this may be related to libc/pthread & TLS handling.

[1]. https://forum.snapcraft.io/t/nvidia-acceleration-on-chrome-and-firefox/4532/

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
sergiocazzolato added a commit to sergiocazzolato/snapd that referenced this pull request Feb 17, 2022
@sergiocazzolato
Squashed 'tests/lib/external/snapd-testing-tools/' changes from dc6be…
c2de964 
…12e76..575f5d2016

575f5d2016 Merge pull request snapcore#13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request snapcore#10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request snapcore#12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
872b64e05b Merge pull request snapcore#11 from Meulengracht/main
aa8799d0f8 tools/repack-kernel: fix SC2061
a44a987381 Merge pull request snapcore#9 from snapcore/check-spread-yaml-files
5cfa7cb84d New shellcheck for spread tasks
a9f6e09e0d Merge pull request snapcore#8 from Meulengracht/main
cd7926a85f New check-test-format tool
210b232d9c tools/repack-kernel: fix additional shellchecks
ac67796b5c Merge pull request #7 from Meulengracht/main
13fd7270b7 tools/repack-kernel: PR feedback comments
3844702a17 Merge pull request #6 from Meulengracht/main
4afdeefe42 tests/repack-kernel: move restore above execute to pass ./run-checks
e755eca0f8 Merge pull request #5 from Meulengracht/main
6199fc48f9 tools: add core22 targets in os.query
057919c07a Merge pull request #4 from mvo5/remove-ubuntu-21.04-eol
26b35af9b3 Merge pull request #1 from Meulengracht/main
b0fa82117a many: remove Ubuntu 21.04 (hirsute), it's EOL
878fd76976 repack-kernel: remove some cds and add a newline
4b84abd26b repack-kernel: fix issue in test related to wrong help message pattern
2e7fd675a7 repack-kernel: additional fixes to error messages. additional failure tests
545d72ef20 repack-kernel: additional fixes to tool based on feedback, additional tests
da1e43b4bb repack-kernel: change the install apt command for initramfs
131bcd11b2 repack-kernel: fix prepare command and error message having to much copy-pasta
9b2aef208f repack-kernel: add more tests, fix setup command
b98c024146 review feedback
5b76f3fe99 remove nested.sh, restructure repack-kernel and add test
0e5b5052e3 nested.sh: add missing command for waiting for snap command
9591a6e700 nested.sh: fix issues with OVMF
4db61f2b13 remove scripts that were hard to reuse, handle missing variables
9b956243e1 use env for path instead of hardcoding
b8e9d73349 core: add shared shell scripts for building image and controlling the L2 VM

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 575f5d201619fc18f83c404222fc98e2ff696b04
sergiocazzolato added a commit that referenced this pull request Feb 25, 2022
@sergiocazzolato
tests: include new testing tools and utils (#11399)
5d6b7ab 
* Squashed 'tests/lib/external/snapd-testing-tools/' changes from dc6be12e76..575f5d2016

575f5d2016 Merge pull request #13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request #10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request #12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
872b64e05b Merge pull request #11 from Meulengracht/main
aa8799d0f8 tools/repack-kernel: fix SC2061
a44a987381 Merge pull request #9 from snapcore/check-spread-yaml-files
5cfa7cb84d New shellcheck for spread tasks
a9f6e09e0d Merge pull request #8 from Meulengracht/main
cd7926a85f New check-test-format tool
210b232d9c tools/repack-kernel: fix additional shellchecks
ac67796b5c Merge pull request #7 from Meulengracht/main
13fd7270b7 tools/repack-kernel: PR feedback comments
3844702a17 Merge pull request #6 from Meulengracht/main
4afdeefe42 tests/repack-kernel: move restore above execute to pass ./run-checks
e755eca0f8 Merge pull request #5 from Meulengracht/main
6199fc48f9 tools: add core22 targets in os.query
057919c07a Merge pull request #4 from mvo5/remove-ubuntu-21.04-eol
26b35af9b3 Merge pull request #1 from Meulengracht/main
b0fa82117a many: remove Ubuntu 21.04 (hirsute), it's EOL
878fd76976 repack-kernel: remove some cds and add a newline
4b84abd26b repack-kernel: fix issue in test related to wrong help message pattern
2e7fd675a7 repack-kernel: additional fixes to error messages. additional failure tests
545d72ef20 repack-kernel: additional fixes to tool based on feedback, additional tests
da1e43b4bb repack-kernel: change the install apt command for initramfs
131bcd11b2 repack-kernel: fix prepare command and error message having to much copy-pasta
9b2aef208f repack-kernel: add more tests, fix setup command
b98c024146 review feedback
5b76f3fe99 remove nested.sh, restructure repack-kernel and add test
0e5b5052e3 nested.sh: add missing command for waiting for snap command
9591a6e700 nested.sh: fix issues with OVMF
4db61f2b13 remove scripts that were hard to reuse, handle missing variables
9b956243e1 use env for path instead of hardcoding
b8e9d73349 core: add shared shell scripts for building image and controlling the L2 VM

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 575f5d201619fc18f83c404222fc98e2ff696b04

* Usinr new utils and tools from the snapd-testing-tools project

* Squashed 'tests/lib/external/snapd-testing-tools/' changes from 575f5d2016..61a4c3142d

61a4c3142d Merge pull request #14 from snapcore/include-support-s390x
3a1a65f6e1 Update the comments about shellchek
5ddfb7e1db New support for s390x arch in os.query tool

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 61a4c3142d43d3e72330fd570ee16106d861ed24
sergiocazzolato added a commit to sergiocazzolato/snapd that referenced this pull request Mar 1, 2022
@sergiocazzolato
Squashed 'tests/lib/external/snapd-testing-tools/' changes from 872b6…
fb4e93b 
…4e05b..58418c3f7e

58418c3f7e Merge pull request snapcore#15 from snapcore/testing-jammy
f015a34899 Fix issue about how info is saved for Debug output
1ee4240e79 Adding jammy to the test systems in spread.yaml
61a4c3142d Merge pull request snapcore#14 from snapcore/include-support-s390x
3a1a65f6e1 Update the comments about shellchek
5ddfb7e1db New support for s390x arch in os.query tool
575f5d2016 Merge pull request snapcore#13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request snapcore#10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request snapcore#12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
5cfa7cb84d New shellcheck for spread tasks

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 58418c3f7ed998e3f327f5104588ee8c8dc48651
sergiocazzolato added a commit that referenced this pull request Mar 8, 2022
@sergiocazzolato
Squashed 'tests/lib/external/snapd-testing-tools/' changes from 872b6…
dd799e0 
…4e05b..58418c3f7e (#11451)

58418c3f7e Merge pull request #15 from snapcore/testing-jammy
f015a34899 Fix issue about how info is saved for Debug output
1ee4240e79 Adding jammy to the test systems in spread.yaml
61a4c3142d Merge pull request #14 from snapcore/include-support-s390x
3a1a65f6e1 Update the comments about shellchek
5ddfb7e1db New support for s390x arch in os.query tool
575f5d2016 Merge pull request #13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request #10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request #12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
5cfa7cb84d New shellcheck for spread tasks

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 58418c3f7ed998e3f327f5104588ee8c8dc48651
sergiocazzolato added a commit to sergiocazzolato/snapd that referenced this pull request Mar 29, 2022
@sergiocazzolato
Squashed 'tests/lib/external/snapd-testing-tools/' changes from 872b6…
6d30b43 
…4e05b..1a986df8d5

1a986df8d5 Merge pull request snapcore#17 from snapcore/new-snaps-cleanup-tool
29600af53a Fixing os.paths test for arch linux
e5cdb06053 Minor fixes based on comment reviews
89a0073b88 Run cleanup tests just on systems with snapd pre-installed
19d216a1b9 New tools to get os paths, snap names and cleanup the snaps
a36ee8451a Merge pull request snapcore#16 from snapcore/add-codespell
f837691b62 Adding codespell tool to github workflow
58418c3f7e Merge pull request snapcore#15 from snapcore/testing-jammy
f015a34899 Fix issue about how info is saved for Debug output
1ee4240e79 Adding jammy to the test systems in spread.yaml
61a4c3142d Merge pull request snapcore#14 from snapcore/include-support-s390x
3a1a65f6e1 Update the comments about shellchek
5ddfb7e1db New support for s390x arch in os.query tool
575f5d2016 Merge pull request snapcore#13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request snapcore#10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request snapcore#12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
5cfa7cb84d New shellcheck for spread tasks

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 1a986df8d5e66459ec9aa2498a1e9c7d7e419284
sergiocazzolato added a commit to sergiocazzolato/snapd that referenced this pull request Apr 8, 2022
@sergiocazzolato
Squashed 'tests/lib/external/snapd-testing-tools/' changes from 872b6…
12aed4d 
…4e05b..5c77d93bd6

5c77d93bd6 Merge pull request snapcore#18 from snapcore/tests-new-remote-tools
3cef4b69b4 Updating timeouts
2c6bf4bd48 Using local vars and removing wait-for tool
8642893803 Test fixes
a14ec4ea88 New remote tools
4545a5e5be Merge branch 'main' into tests-new-remote-tools
1a986df8d5 Merge pull request snapcore#17 from snapcore/new-snaps-cleanup-tool
29600af53a Fixing os.paths test for arch linux
e5cdb06053 Minor fixes based on comment reviews
a791ae89cb New remote tools
89a0073b88 Run cleanup tests just on systems with snapd pre-installed
19d216a1b9 New tools to get os paths, snap names and cleanup the snaps
a36ee8451a Merge pull request snapcore#16 from snapcore/add-codespell
f837691b62 Adding codespell tool to github workflow
58418c3f7e Merge pull request snapcore#15 from snapcore/testing-jammy
f015a34899 Fix issue about how info is saved for Debug output
1ee4240e79 Adding jammy to the test systems in spread.yaml
61a4c3142d Merge pull request snapcore#14 from snapcore/include-support-s390x
3a1a65f6e1 Update the comments about shellchek
5ddfb7e1db New support for s390x arch in os.query tool
575f5d2016 Merge pull request snapcore#13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request snapcore#10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request snapcore#12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
5cfa7cb84d New shellcheck for spread tasks

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 5c77d93bd6508f989b517a8cfb9b3235adbda012
sergiocazzolato added a commit that referenced this pull request May 13, 2022
@sergiocazzolato
tests: use new snaps.name and snaps.cleanup tools (#11599)
ddfc54b 
* Squashed 'tests/lib/external/snapd-testing-tools/' changes from 872b64e05b..1a986df8d5

1a986df8d5 Merge pull request #17 from snapcore/new-snaps-cleanup-tool
29600af53a Fixing os.paths test for arch linux
e5cdb06053 Minor fixes based on comment reviews
89a0073b88 Run cleanup tests just on systems with snapd pre-installed
19d216a1b9 New tools to get os paths, snap names and cleanup the snaps
a36ee8451a Merge pull request #16 from snapcore/add-codespell
f837691b62 Adding codespell tool to github workflow
58418c3f7e Merge pull request #15 from snapcore/testing-jammy
f015a34899 Fix issue about how info is saved for Debug output
1ee4240e79 Adding jammy to the test systems in spread.yaml
61a4c3142d Merge pull request #14 from snapcore/include-support-s390x
3a1a65f6e1 Update the comments about shellchek
5ddfb7e1db New support for s390x arch in os.query tool
575f5d2016 Merge pull request #13 from snapcore/new-utils-section
4701612434 avoid installing and removing snapd in ubuntu focal
4d0317633d shellcheck in xenial is not needed
d95cb2e627 Moving some tools to the new utils section
839a0ce808 Merge pull request #10 from snapcore/new-spread-shellcheck-tool
5d5efd6fbe Merge pull request #12 from snapcore/run-shellchek-in-old-version
497b7d691f Force testing shellchek with versions 0.8 and 0.7
b3cb5a5a0a Update the copyright
5cfa7cb84d New shellcheck for spread tasks

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 1a986df8d5e66459ec9aa2498a1e9c7d7e419284

* Using new snaps.name and snaps.cleanup tools

These tools are imported from snapd-testing-tools

* cleanup tool will not be in bin

* Fix shellcheck

* Update missing tests

* Fix shellcheck

* Squashed 'tests/lib/external/snapd-testing-tools/' changes from 1a986df8d5..53ca1b3b70

53ca1b3b70 Merge pull request #21 from snapcore/fix-some-shellcheks
d380a8065e Fix shellchecks
ad410d44cd Merge pull request #20 from snapcore/fixes-on-remote-tools
80bfd6d85b Updates based on review comments in snapd project
5c77d93bd6 Merge pull request #18 from snapcore/tests-new-remote-tools
3cef4b69b4 Updating timeouts
2c6bf4bd48 Using local vars and removing wait-for tool
8642893803 Test fixes
a14ec4ea88 New remote tools
4545a5e5be Merge branch 'main' into tests-new-remote-tools
a791ae89cb New remote tools

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: 53ca1b3b709e685b7910e4b559f182dd78039029

* Make snaps.name executable
robert-ancell pushed a commit to robert-ancell/snapd that referenced this pull request Aug 24, 2023
@olivercalder
Merge pull request snapcore#10 from robert-ancell/prompting-empty-req…
af7367d 
…uests

prompting: Return empty list instead of null when unable to get prompt requests
flocko-motion pushed a commit to ML-PA-Consulting-GmbH/snapd that referenced this pull request Feb 2, 2024
@jawn-smith
Merge pull request snapcore#10 from GlenPickle/FR-1453
0df4a20 
FR-1453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chipaca @niemeyer @come-maiz