boot: load bits of kernel command line from gadget snaps #10130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load the kernel command line arguments provided by the gadget if the path to a gadget snap directory or file is provided. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
…t-load-cmdline-from-gadget
…t-load-cmdline-from-gadget
pedronis
approved these changes
Apr 12, 2021
| extraArgs := "" | ||
| if gadgetDirOrSnapPath != "" { | ||
| sf, err := snapfile.Open(gadgetDirOrSnapPath) |
There was a problem hiding this comment.
shouldn't we merge this Open into gadget.KernelCommandLineFromGadget ? do we have a case where we have the container already?
There was a problem hiding this comment.
Yes, that's a good point. I'll do it in a followup so that #10134 is unblocked first, if that's ok with you.
…t-load-cmdline-from-gadget
|
All failures look unreleated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #10119, the relevant commit is: af2862f
The branch adds support for loading bits of kernel command line from the gadget. Currently only cmdline.extra is supported.