cmd/snap: introduce 'snap quota' command #10197
Conversation
stolowski
added
Needs Samuele review
client/quota.go
Outdated
| GroupName string `json:"group-name"` | ||
| Parent string `json:"parent,omitempty"` | ||
| Snaps []string `json:"snaps,omitempty"` | ||
| MaxMemory int64 `json:"max-memory"` |
There was a problem hiding this comment.
should this be uint64 (negative memory doesn't have a meaning) ?
There was a problem hiding this comment.
Good point, done, although we have inconsistencies elsewhere in existing helpers, so unfortunately there is now int64/uint64 casting (cleaning the helpers up is probably a material for a followup since it would affect unrelated code).
There was a problem hiding this comment.
sounds good, I think cleanups to the helpers would be good but yeah are unnecessary at this point
| if maxMemory == "" && x.Parent == "" && len(x.Positional.Snaps) == 0 { | ||
| return x.showQuotaGroupInfo(x.Positional.GroupName) |
There was a problem hiding this comment.
to be clear, we don't need to handle the case where the group name is empty, since go-flags will handle that case for us since we use required: true, correct?
| } | ||
|
|
||
| func (x *cmdQuota) showQuotaGroupInfo(groupName string) error { | ||
| w := Stdout |
There was a problem hiding this comment.
this should probably be a tabWriter() instead so that things line up in a nice format
There was a problem hiding this comment.
Hmm I'm not sure, I tried it and it's doing weird things. I think it's geared towards tabular output with constant number of columns, whereas here the output is yamlish.
There was a problem hiding this comment.
well I suppose we can revisit it and fix it later, but tabWriter is used in snap model which is also YAMLish
There was a problem hiding this comment.
Ok, I'll revisit this in a followup after all other PRs.
There was a problem hiding this comment.
Yeah, I think we can do this later, we should just ensure we capture it somewhere.
stolowski
force-pushed
the
resource-groups/cli
branch
from
e017d15
to
a974eb2
Compare
stolowski
force-pushed
the
resource-groups/cli
branch
from
78fe875
to
15e50dc
Compare
| } | ||
|
|
||
| func (x *cmdQuota) showQuotaGroupInfo(groupName string) error { | ||
| w := Stdout |
There was a problem hiding this comment.
Yeah, I think we can do this later, we should just ensure we capture it somewhere.
| if groupName == "" { | ||
| return xerrors.Errorf("cannot create or update quota group without a name") | ||
| } | ||
| // TODO: use naming.ValidateQuotaGroup() |
There was a problem hiding this comment.
(nitpick^2) given that the server side will validate I'm not sure we really need to client side validate but I'm happy to keep this todo
Introduce 'snap quota' command along with client methods with support for creating/updating and querying info for single quota group.