seed/seedwriter: fail early when system seed directory exists #10220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail early when creating a Core 20 seed when the target directory exists. This helps to prevent a situation when creating seed gets interrupted and gets restarted. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
pedronis
reviewed
Apr 30, 2021
| s.opts.Label = "20191003" | ||
| for _, t := range tests { | ||
| baseLabel := "20191003" | ||
| for idx, t := range tests { |
There was a problem hiding this comment.
we could also remove the dir instead? I don't have a very strong preference but wanted to mention it
There was a problem hiding this comment.
using the index as a suffix seems reasonable enough to me
pedronis
reviewed
Apr 30, 2021
…er-fail-when-dir-is-present
Seedwriter now fails early when the system directory already exists Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
pedronis
reviewed
May 18, 2021
…edwriter-fail-when-dir-is-present
…ry already exists Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
pedronis
reviewed
May 18, 2021
seed/seedwriter/writer.go
Outdated
| @@ -421,12 +421,28 @@ func (w *Writer) SetOptionsSnaps(optSnaps []*OptionsSnap) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // ErrSystemAlreadyExists is an error returned when given seed system already | |||
| // exists. | |||
| type ErrSystemAlreadyExists struct { | |||
There was a problem hiding this comment.
error structs need to be called SystemAlreadyExistsError
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
anonymouse64
approved these changes
May 18, 2021
| s.opts.Label = "20191003" | ||
| for _, t := range tests { | ||
| baseLabel := "20191003" | ||
| for idx, t := range tests { |
There was a problem hiding this comment.
using the index as a suffix seems reasonable enough to me
|
Feels like restarting the spread jobs for the 3rd time is wasteful. @mvo5 can you merge this PR? The failure on 14.04 is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail early when creating a Core 20 seed when the target directory exists. This
helps to prevent a situation when creating seed gets interrupted and gets
restarted.