release-tool/changelog.py: misc fixes from real world usage #10315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arg too The LP bug for the release is different for every new major release, so we need to specify this when generating the changelog. We could eventually figure out what it should be for minor releases, but for now just make it mandatory to specify it in the arguments to the script. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Lines can actually be exactly 72 characters long. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Somehow, on my system the %z format string was empty, resulting in the empty string being used for the timezone, which does not match the expected format for the opensuse changelog spec file. In this case, if we detect that there is no timezone, use utc time and use the +0000 as the timezone. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
The correct format is "Mon Mar 08 2021", not "Thu 27 May 2021". Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
bugfix/changelog-py-fixes
branch
from
cd7c89c
to
b21fbf9
Compare
anonymouse64
added a commit
to anonymouse64/snapd
that referenced
this pull request
May 27, 2021
This was generated incorrectly by release-tools/changelog.py, but is now fixed in snapcore#10315. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
added a commit
to anonymouse64/snapd
that referenced
this pull request
May 27, 2021
This was generated incorrectly by release-tools/changelog.py, but is now fixed in snapcore#10315. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
This was referenced May 27, 2021
bboozzoo
approved these changes
May 28, 2021
Thanks to Maciej for spotting this Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Thanks to Maciej for sorting out the right format here, as we were using an incorrect or inconsistent format for the past few releases, likely cargo culting the first incorrect format that was introduced last year. Also we should just always use UTC for this, so we can simplify the code slightly. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous little fixes I needed to apply to actually use the script for the 2.51 release.