tests: clean snaps.sh helper #10343
Merged
tests: clean snaps.sh helper #10343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps.sh The change includes: . Start using the tool snaps-state . Remove includes for snaps.sh . Cleanup snaps.sh helper . Update snaps-state too to include repack with target dir
mvo5
approved these changes
Aug 16, 2021
| @@ -88,7 +85,7 @@ execute: | | |||
| if [ "$NESTED_BUILD_SNAPD_FROM_CURRENT" = "false" ]; then | |||
| if os.query is-xenial; then | |||
| # build the core snap for this run | |||
| repack_snapd_deb_into_core_snap "$PWD" | |||
| "$TESTSTOOLS"/snaps-state repack_snapd_deb_into_snap core "$PWD" | |||
There was a problem hiding this comment.
I guess we could remove "$PWD" here as it's the default?
Codecov Report
@@ Coverage Diff @@
## master #10343 +/- ##
==========================================
- Coverage 80.71% 78.31% -2.40%
==========================================
Files 727 882 +155
Lines 58158 99308 +41150
==========================================
+ Hits 46940 77777 +30837
- Misses 7544 16638 +9094
- Partials 3674 4893 +1219
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change includes:
. Start using the tool snaps-state
. Remove includes for snaps.sh
. Cleanup snaps.sh helper
. Update snaps-state too to include repack with target dir