Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

o/servicestate/quota_control.go: enforce minimum of 4K for quota groups #10346

Merged
merged 10 commits into from
Jun 18, 2021
Merged

o/servicestate/quota_control.go: enforce minimum of 4K for quota groups #10346

merged 10 commits into from
Jun 18, 2021

Commits on Jun 7, 2021

  1. o/servicestate/quota_control.go: enforce minimum of 4K for quota groups 

    This is to support nesting and to avoid confusing situations like being able to
create empty but nested quota groups which trigger oom-killer to be invoked on
the empty quota group because newer systems require at least 4K for the
accounting of a sub-group.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    54fcd36 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Merge branch 'master' into feature/quota-groups-remastered-deluxe-dia… 

    …mond-edition-2.5

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    3d891e0 View commit details
    Browse the repository at this point in the history

  2. tests/main/snap-quota-groups: adjust memory limit to be minimum allowed 

    We now have a minimum memory limit of 4K, so we can't use 1K anymore.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7c66d18 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. tests/main/snap-quota-groups: adjust memory limit to be slightly larger 

    Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d28295b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Merge branch 'master' into feature/quota-groups-remastered-deluxe-dia… 

    …mond-edition-2.5

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    894388b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/quota-groups-remastered-deluxe-dia… 

    …mond-edition-2.5

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    e03fc28 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Merge branch 'master' into feature/quota-groups-remastered-deluxe-dia… 

    …mond-edition-2.5

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    bef38f5 View commit details
    Browse the repository at this point in the history

  2. o/servicestate/quota_handlers.go: adjust error message for clarity 

    This makes it more clear what the actual necessary size is, which is 4K + 1.

Thanks to Samuele for pointing this out.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    3b1bd0a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Merge remote-tracking branch 'upstream/master' into feature/quota-gro… 

    …ups-remastered-deluxe-diamond-edition-2.5
    @mvo5
    mvo5 committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    ca648fe View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Merge branch 'master' into feature/quota-groups-remastered-deluxe-dia… 

    …mond-edition-2.5

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
    @anonymouse64
    anonymouse64 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    6731f9e View commit details
    Browse the repository at this point in the history