o/configstate/configcore: support snap set system swap.size=... (2.51) #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a handler for the system swap option which manipulates /etc/default/swapfile and swapfile.service. This option works both with systemd around at runtime, and without during the initrd for example when only the rootfs is available. In order to properly handle this when the key is not set without running systemd unnecessarily, we need to use GetPristine to indicate if the value was changed or not. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
We want to make sure that the swap size is an even integer number of megabytes and that it's not too small, and that it's not negative. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
….size Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Thanks to Maciej for spotting this. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
stolowski
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #9932 for 2.51 to allow a clean cherry pick of #10446