o/snapstate: fix populating of affectedSnapInfo.AffectingSnaps for marking self as affecting #10475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self as affecting.
stolowski
added
Refresh control
Simple 😃
mardy
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special case for populating affectedSnapInfo for the snap that gets refreshed and may want to control his own refresh (hold itself) wasn't correct and didn't fill affectingSnaps. As a result, the gate-auto-refresh hook of such snap didn't have affecting-snaps set correctly and --hold or --proceed wouldn't update hold state for itself.