Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/hookstate: allow snapctl refresh --proceed from snaps #10528

Merged

Conversation

stolowski
Copy link
Contributor

@stolowski stolowski commented Jul 14, 2021

Allow snapctl refresh --proceed outside of hooks.

@stolowski stolowski added ⛔ Blocked Refresh control Needs Samuele review Needs a review from Samuele before it can land labels Jul 14, 2021
@stolowski stolowski force-pushed the refresh-control/proceed-from-snap branch 2 times, most recently from 2bd3a9f to dd18c95 Compare August 16, 2021 12:50
@stolowski stolowski force-pushed the refresh-control/proceed-from-snap branch from dd18c95 to d91ab0b Compare August 17, 2021 08:44
@stolowski stolowski force-pushed the refresh-control/proceed-from-snap branch from d91ab0b to 66dfd51 Compare August 17, 2021 10:13
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

overlord/hookstate/ctlcmd/refresh.go Show resolved Hide resolved
Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stolowski stolowski merged commit eb14633 into snapcore:master Aug 18, 2021
@stolowski stolowski deleted the refresh-control/proceed-from-snap branch October 20, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Samuele review Needs a review from Samuele before it can land
Projects
None yet
3 participants