Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/many: remove lxd systemd unit to prevent unexpected leftovers #10560

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

sergiocazzolato
Copy link
Collaborator

This is a temporal, at some point it should be automatically removed
when lxd is uninstalled.

The explanation about this service is:
"The snap.lxd.workaround.service unit is needed by lxd to avoid systemd
wiping the cgroups when snapd disables all the lxd units during refresh
Effectively an empty unit with Delegate=yes which snapd doesn't know
about and so won't be disabled during refresh"

This is to prevent the spread error on postrm-purge test

  • systemctl --no-legend --full
  • grep -E 'snap..*.(service|timer|socket)'
    snap.lxd.workaround.service loaded active exited /bin/true
  • echo 'found unexpected leftovers'
    found unexpected leftovers
  • exit 1

…ge test

This is a temporal, at some point it should be automatically removed
when lxd is uninstalled.

The explanation about this service is:
"The snap.lxd.workaround.service unit is needed by lxd to avoid systemd
wiping the cgroups when snapd disables all the lxd units during refresh
Effectively an empty unit with Delegate=yes which snapd doesn't know
about and so won't be disabled during refresh"
@sergiocazzolato sergiocazzolato added Simple 😃 A small PR which can be reviewed quickly ⚠ Critical High-priority stuff (e.g. to fix master) labels Jul 23, 2021
@sergiocazzolato sergiocazzolato changed the title Remove lxd systemd unit to prevent unexpected leftovers on postrm-purge test Remove lxd systemd unit to prevent unexpected leftovers Jul 23, 2021
Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the tests are green

@anonymouse64 anonymouse64 changed the title Remove lxd systemd unit to prevent unexpected leftovers tests/many: remove lxd systemd unit to prevent unexpected leftovers Jul 23, 2021
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
3 participants