snap/squashfs: handle squashfs-tools 4.5+ #10567
Conversation
bboozzoo
added
⚠ Critical
Arch recently landed an update of squahfs-tools to 4.5 which broke our code. The main difference is that the output of unsquahfs stdout does not contain the header we expected. For instance: google:ubuntu-20.04-64 .../mini/hello# unsquashfs -n -dest . -ll /root/foo.snap Parallel unsquashfs: Using 1 processor 5 inodes (1 blocks) to write drwx------ root/root 55 2021-07-27 11:31 . -rw-r--r-- root/root 0 2021-07-27 11:31 ./data.bin drwxr-xr-x root/root 27 2021-07-27 11:31 ./food drwxr-xr-x root/root 27 2021-07-27 11:31 ./food/bard drwxr-xr-x root/root 3 2021-07-27 11:31 ./food/bard/bazd drwxr-xr-x root/root 45 2021-07-27 11:31 ./meta drwxr-xr-x root/root 58 2021-07-27 11:31 ./meta/hooks -rwxr-xr-x root/root 0 2021-07-27 11:31 ./meta/hooks/bar-hook drwxr-xr-x root/root 26 2021-07-27 11:31 ./meta/hooks/dir -rwxr-xr-x root/root 0 2021-07-27 11:31 ./meta/hooks/dir/baz -rwxr-xr-x root/root 0 2021-07-27 11:31 ./meta/hooks/foo-hook -rw-r--r-- root/root 9 2021-07-27 11:31 ./meta/snap.yaml While on Arch with squashfs 4.5: $ unsquashfs -n -dest . -ll /tmp/check-1302223697476122084/0/foo.snap drwx------ root/root 55 2021-07-27 13:31 . -rw-r--r-- root/root 0 2021-07-27 13:31 ./data.bin drwxr-xr-x root/root 27 2021-07-27 13:31 ./food drwxr-xr-x root/root 27 2021-07-27 13:31 ./food/bard drwxr-xr-x root/root 3 2021-07-27 13:31 ./food/bard/bazd drwxr-xr-x root/root 45 2021-07-27 13:31 ./meta drwxr-xr-x root/root 58 2021-07-27 13:31 ./meta/hooks -rwxr-xr-x root/root 0 2021-07-27 13:31 ./meta/hooks/bar-hook drwxr-xr-x root/root 26 2021-07-27 13:31 ./meta/hooks/dir -rwxr-xr-x root/root 0 2021-07-27 13:31 ./meta/hooks/dir/baz -rwxr-xr-x root/root 0 2021-07-27 13:31 ./meta/hooks/foo-hook -rw-r--r-- root/root 9 2021-07-27 13:31 ./meta/snap.yaml Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/arch-new-squashfs-tools
branch
from
7accaa3
to
dfba7de
Compare
|
Arch is green. Other distros are happy as well. There's some failures related to nfs on Ubuntu 20.04 to 21.10. |
| maybeHeaderRegex.Match(raw) { | ||
| continue | ||
| } else { | ||
| seenHeader = true |
There was a problem hiding this comment.
Nitpick, I found seenHeader name a bit misleading in realation to maybeHeaderRegex; it suggests seenHeader becomes true when we match maybeHeaderRegex while afaiu it is set after we scan first lines (which may or may not contain the optional headers). Maybe rename it to something like pastHeaders or headersScanned?
|
On Fedora 34 I tried the following to fix the problem:
It seems that because of this (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=993233), snapd is unusable. So the workaround is to downgrading the squashfs package to fix the problem. |
|
@gusseppe downgrading squashfs is a good workaround. But I'd wait for Fedora's snap package to upgrade. |
|
@bboozzoo just prepared an update to fedora, you can help in testing it out: https://forum.snapcraft.io/t/snapd-updates-in-fedora/4342/34 |
Arch recently landed an update of squahfs-tools to 4.5 which broke our code. The
main difference is that the output of unsquahfs stdout does not contain the
header we expected. For instance:
While on Arch with squashfs 4.5: