sysconfig/cloudinit.go: measure (but don't use) gadget cloud-init datasource #10572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymouse64
added
UC20
Run nested
anonymouse64
force-pushed
the
feature/uc20-cloud-init-maas-support-2
branch
from
2b85e92
to
76823fd
Compare
6 tasks
|
I opened #10573 which is the full WIP branch that is based on top of this to demonstrate how this code is used, specifically see https://github.com/snapcore/snapd/pull/10573/files#diff-3450862368a77e8ae5d3817feb24a674eadc445a262c1f086d5a3e1a6174ad21L185-R446 for how this is used for decision making |
…asource In a future commit, we will use the result of measuring the datasource settings for the cloud-init config from the gadget, but for now just introduce the machinery to read it. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
feature/uc20-cloud-init-maas-support-2
branch
from
76823fd
to
020a1f9
Compare
anonymouse64
added
the
Needs Samuele review
…_list We previously would just create a list with the duplicated names in it, which didn't break anything but may be confusing for some other bits of code later on. Instead trim out duplicates using a map instead of appending directly into the resultant list. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future commit, we will use the result of measuring the datasource settings
for the cloud-init config from the gadget, but for now just introduce the
machinery to read it.