-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/libsnap-confine-private: move device cgroup files, add helper to deny a device #10576
cmd/libsnap-confine-private: move device cgroup files, add helper to deny a device #10576
Conversation
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
… (v1) Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. The first two commits just move code around and the changes in the last one look fine.
@@ -136,6 +144,16 @@ int sc_device_cgroup_allow(sc_device_cgroup *self, int kind, int major, int mino | |||
return 0; | |||
} | |||
|
|||
int sc_device_cgroup_deny(sc_device_cgroup *self, int kind, int major, int minor) { | |||
if (kind != S_IFCHR && kind != S_IFBLK) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this new check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ce-cgroup-move-around-and-deny
Preparation for reimplementation of snap-device-helper and more device cgroup changes