Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/main/snapd-snap: install 4.x snapcraft to build the snapd snap #10579

Merged

Conversation

anonymouse64
Copy link
Member

The snapd snap does not yet specify a base, so it is no longer buildable with
snapcraft 5.x, which drops support for baseless and base: core snaps.

Instead, use 4.x channel of snapcraft which does still support this scenario.

The snapd snap does not yet specify a base, so it is no longer buildable with
snapcraft 5.x, which drops support for baseless and base: core snaps.

Instead, use 4.x channel of snapcraft which does still support this scenario.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64 anonymouse64 added the ⚠ Critical High-priority stuff (e.g. to fix master) label Jul 30, 2021
Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Jul 30, 2021
Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvo5 mvo5 merged commit c8e3eb0 into snapcore:master Aug 3, 2021
@mvo5 mvo5 added this to the 2.52 milestone Aug 3, 2021
@anonymouse64 anonymouse64 deleted the bugfix/snapcraft-4-x-for-snapd-snap branch August 27, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
5 participants