Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/test.yaml: use snapcraft 4.x to build the snapd snap #10601

Conversation

anonymouse64
Copy link
Member

5.x doesn't support the snapd snap as currently supported, so we need to build
with 4.x for the time being.

5.x doesn't support the snapd snap as currently supported, so we need to build
with 4.x for the time being.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64 anonymouse64 added ⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run labels Aug 9, 2021
@anonymouse64 anonymouse64 reopened this Aug 9, 2021
Copy link
Contributor

@jhenstridge jhenstridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvo5 mvo5 merged commit 0c6c7b0 into snapcore:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
4 participants