Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix core-early-config test to use tests.nested tool #10612

Merged

Conversation

sergiocazzolato
Copy link
Collaborator

The execute_remove is not used anymore, it was replaced by tests.nested

The execute_remove is not used anymore, it was replaced by tests.nested
@sergiocazzolato sergiocazzolato added the Run nested The PR also runs tests inluded in nested suite label Aug 12, 2021
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch, sorry for that

Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for catching this

Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anonymouse64 anonymouse64 merged commit 5edaf37 into snapcore:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run nested The PR also runs tests inluded in nested suite
Projects
None yet
4 participants