-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: changelog for 2.51.5 to master #10621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.x doesn't support the snapd snap as currently supported, so we need to build with 4.x for the time being. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
…faces. The /proc/tty/drivers can be used by apps whether a tty device is a serial port.
The mbim-proxy daemon is started by the ModemManager service. The modem's app which wants to send MBIM messages will connect to the mbim-proxy daemon via the unix socket. The mbim-proxy daemon uses the the abstract socket path "mbim-proxy". The modem-manager interface needs a corresponding update. This provides that update. References: https://bugs.launchpad.net/austin/+bug/1936374
…arg too The LP bug for the release is different for every new major release, so we need to specify this when generating the changelog. We could eventually figure out what it should be for minor releases, but for now just make it mandatory to specify it in the arguments to the script. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Lines can actually be exactly 72 characters long. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Somehow, on my system the %z format string was empty, resulting in the empty string being used for the timezone, which does not match the expected format for the opensuse changelog spec file. In this case, if we detect that there is no timezone, use utc time and use the +0000 as the timezone. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
The correct format is "Mon Mar 08 2021", not "Thu 27 May 2021". Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Thanks to Maciej for spotting this Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Thanks to Maciej for sorting out the right format here, as we were using an incorrect or inconsistent format for the past few releases, likely cargo culting the first incorrect format that was introduced last year. Also we should just always use UTC for this, so we can simplify the code slightly. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Restore the default behaviour of acking the newly created assertions by default, but add a --noack option to prevent this from happening. Use this option in the nested tests.
The 'p' variable was unused. When removing it, we send the stdout to /dev/null, in order not to alter the output of our function.
… install (snapcore#10608) * tests/lib/store.sh: allow adding extra bits to snap-declaration via opts This is needed in order to customize the snap-declaration with i.e. plugs or slots or other special things granted through the snap-declaration assertion to the snap. Signed-off-by: Ian Johnson <ian.johnson@canonical.com> * tests/lib/nested.sh: add NESTED_FAKESTORE_SNAP_DECL_PC_GADGET env var This is used add special extra custom snap-declaration bits to the declaration for tests which use the fakestore but need extra permissions to do things in hooks or services for the gadget snap. Signed-off-by: Ian Johnson <ian.johnson@canonical.com> * o/devicestate/handlers_install.go: add workaround to create dirs for install For UC20 install mode, we have devices which need to install files into the run mode system before rebooting into install mode. The temporary solution designed for this was to use the install-device hook with system-files providing write access to the /run/mnt/ubuntu-data/system-data/_writable_defaults/... directory where ubuntu-data is mounted during install mode. That seemed to work fine in devmode, but the issue in strict mode is that system-files only grants permissions to create that specific file, it doesn't grant permission to create any of the parent directories the file lives in. So, temporarily for this device to be released and shipped, create those directories at the end of the setup-run-system task, which runs before the install-device hook, thus ensuring that the hook is successful. Also add a spread test for this situation. Signed-off-by: Ian Johnson <ian.johnson@canonical.com> * tests/core20-install-device-file-install-via-hook-hack: also check dir perms As suggested by Samuele, also check the permissions of the directories that we are creating here. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
…or 2.51 We do not yet have tests.nested on release/2.51, so revert this test for that branch to use the old commands. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Arch recently landed an update of squahfs-tools to 4.5 which broke our code. The main difference is that the output of unsquahfs stdout does not contain the header we expected. For instance: google:ubuntu-20.04-64 .../mini/hello# unsquashfs -n -dest . -ll /root/foo.snap Parallel unsquashfs: Using 1 processor 5 inodes (1 blocks) to write drwx------ root/root 55 2021-07-27 11:31 . -rw-r--r-- root/root 0 2021-07-27 11:31 ./data.bin drwxr-xr-x root/root 27 2021-07-27 11:31 ./food drwxr-xr-x root/root 27 2021-07-27 11:31 ./food/bard drwxr-xr-x root/root 3 2021-07-27 11:31 ./food/bard/bazd drwxr-xr-x root/root 45 2021-07-27 11:31 ./meta drwxr-xr-x root/root 58 2021-07-27 11:31 ./meta/hooks -rwxr-xr-x root/root 0 2021-07-27 11:31 ./meta/hooks/bar-hook drwxr-xr-x root/root 26 2021-07-27 11:31 ./meta/hooks/dir -rwxr-xr-x root/root 0 2021-07-27 11:31 ./meta/hooks/dir/baz -rwxr-xr-x root/root 0 2021-07-27 11:31 ./meta/hooks/foo-hook -rw-r--r-- root/root 9 2021-07-27 11:31 ./meta/snap.yaml While on Arch with squashfs 4.5: $ unsquashfs -n -dest . -ll /tmp/check-1302223697476122084/0/foo.snap drwx------ root/root 55 2021-07-27 13:31 . -rw-r--r-- root/root 0 2021-07-27 13:31 ./data.bin drwxr-xr-x root/root 27 2021-07-27 13:31 ./food drwxr-xr-x root/root 27 2021-07-27 13:31 ./food/bard drwxr-xr-x root/root 3 2021-07-27 13:31 ./food/bard/bazd drwxr-xr-x root/root 45 2021-07-27 13:31 ./meta drwxr-xr-x root/root 58 2021-07-27 13:31 ./meta/hooks -rwxr-xr-x root/root 0 2021-07-27 13:31 ./meta/hooks/bar-hook drwxr-xr-x root/root 26 2021-07-27 13:31 ./meta/hooks/dir -rwxr-xr-x root/root 0 2021-07-27 13:31 ./meta/hooks/dir/baz -rwxr-xr-x root/root 0 2021-07-27 13:31 ./meta/hooks/foo-hook -rw-r--r-- root/root 9 2021-07-27 13:31 ./meta/snap.yaml Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Update changelog with the 2.51.5 changes. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
mvo5
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
bboozzoo
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog for 2.51.5 to prevent the edge core builds from rolling back in version number to 2.51.4.