Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-aux: build with go-1.13 in the snapcraft build too #10629

Merged
merged 1 commit into from
Aug 17, 2021
Merged

build-aux: build with go-1.13 in the snapcraft build too #10629

merged 1 commit into from
Aug 17, 2021

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Aug 17, 2021

Broken out from #10559 thanks to Ian for spotting this.

@mvo5 mvo5 added the Simple 😃 A small PR which can be reviewed quickly label Aug 17, 2021
bboozzoo
bboozzoo approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anonymouse64
anonymouse64 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for this

@mvo5 mvo5 merged commit e68da2c into snapcore:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboozzoo bboozzoo bboozzoo approved these changes

@anonymouse64 anonymouse64 anonymouse64 approved these changes

Assignees
No one assigned
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Milestone
No milestone
3 participants
@mvo5 @bboozzoo @anonymouse64