Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove the test user just when it was installed on create-user-2 test #10637

Conversation

sergiocazzolato
Copy link
Collaborator

In case the create-user-2 test fails and the user was not installed, then we need to
check the user was created before removing it, otherwise the restore phase fails and the machine is discarded.

When this happens with external backend the whole execution is lost because of that error.

In case the test fails and the user is not installed, then we need to
check that before removing the user, otherwise the restore phase fails
and the machine is discarded. When this happens with external backend
the whole execution is lost becuase of this test.
@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Aug 18, 2021
Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergiocazzolato sergiocazzolato merged commit a37bb57 into snapcore:master Aug 19, 2021
Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment that it would be nice to see old tests like these migrate away from using -e managed.device in restore section and instead just used tests.cleanup defer ... instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
4 participants