Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: stop the service when is active in test interfaces-firewall-control test #10638

Conversation

sergiocazzolato
Copy link
Collaborator

In case the service is not active, the restore fails to stop the service and the machine is discarded.

In case the restore fails when using the external backend, the whole run is lost.

…rol test

In case the service is not active, the restore fails stopping the
service and the machine is discarded.

In case the restore fails when using the external backend, the whole run
is lost.
@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Aug 18, 2021
Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stolowski stolowski merged commit 138a215 into snapcore:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
3 participants