tests: set to 10 minutes the kill timeout for tests failing on slow boards #10664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these tests are failing on pi2 and pi3 in the lab with kill timeout. Some boards are getting slow and the idea is to move from 5m to 10m to avoid those issues. The affected tests are the ones that run on ubuntu core.
Codecov Report
@@ Coverage Diff @@
## master #10664 +/- ##
==========================================
- Coverage 80.71% 78.32% -2.40%
==========================================
Files 727 882 +155
Lines 58158 99360 +41202
==========================================
+ Hits 46940 77819 +30879
- Misses 7544 16649 +9105
- Partials 3674 4892 +1218
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mvo5
approved these changes
Aug 23, 2021
| @@ -3,7 +3,7 @@ summary: "Check that refresh-modes works" | |||
| # takes >1.5min to run | |||
| backends: [-autopkgtest] | |||
|
|
|||
| kill-timeout: 12m | |||
| kill-timeout: 10m | |||
There was a problem hiding this comment.
(nitpick) here the time decreases by 2min, is that intentional?
There was a problem hiding this comment.
Yes, see the bottom of PR desc: The test services-refresh-mode initially was in 5 minutes, then moved to 12 but when tested with 10m it works fine.
bboozzoo
approved these changes
Aug 24, 2021
|
Test failures are unrealted, @mvo5 can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these tests are failing on pi2 and pi3 in the lab with kill
timeout.
Some boards are getting slow and the idea is to move from 5m to 10m to
avoid those issues.
The affected tests are the ones that run on ubuntu core.
The test services-refresh-mode initially was in 5 minutes, then moved to 12 but when tested with 10m it works fine.