Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/lib/prepare.sh: use core20 from beta channel temporarily #10708

Conversation

anonymouse64
Copy link
Member

The core20 snap on edge currently makes all GCE spread runs fail somehow.

@anonymouse64 anonymouse64 added ⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly labels Sep 1, 2021
Copy link
Collaborator

@sergiocazzolato sergiocazzolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #10708 (b1593e9) into master (8f74175) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10708      +/-   ##
==========================================
- Coverage   78.36%   78.35%   -0.01%     
==========================================
  Files         884      884              
  Lines       99517    99517              
==========================================
- Hits        77985    77977       -8     
- Misses      16635    16640       +5     
- Partials     4897     4900       +3     
Flag Coverage Δ
unittests 78.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../snapcore/snapd/osutil/udev/netlink/rawsockstop.go 66.66% <0.00%> (-4.77%) ⬇️
...ithub.com/snapcore/snapd/daemon/api_connections.go 92.51% <0.00%> (-1.07%) ⬇️
...b.com/snapcore/snapd/overlord/hookstate/hookmgr.go 74.17% <0.00%> (-0.67%) ⬇️
...com/snapcore/snapd/overlord/ifacestate/handlers.go 64.63% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f74175...b1593e9. Read the comment docs.

@anonymouse64
Copy link
Member Author

hmm uc20 is still failing though we at least can shell into the system now after it reboots 🤔 I will leave this to someone in EU to debug tomorrow morning

Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvo5
Copy link
Contributor

mvo5 commented Sep 1, 2021

This is strange, I cannot reproduce the issue with qemu, core20 edge seems to be fine here. There was a new edge snap yesterday with https://people.canonical.com/~mvo/core20-changes/html/edge/'20210826'r1090_'20210831'r1097.html so it could be related to this but it's strange that we only see it in google.

@sergiocazzolato
Copy link
Collaborator

I see the core20 is in channel latest/edge, I think there was a refresh

root@sep011136-995955:~# snap list
Name Version Rev Tracking Publisher Notes
core20 20210831 1097 latest/edge canonical✓ base
pc 20-0.4 115 20/edge canonical✓ gadget
pc-kernel 5.4.0-83.93.1 x1 - - kernel
snapd 2.51.7+git1522.gc980bde x1 - - snapd
test-snapd-rsync-core20 3.1.3 11 latest/edge test-snaps-canonical devmode

@sergiocazzolato
Copy link
Collaborator

This is the journal log and snap changes:
https://paste.ubuntu.com/p/RDspjSKbkY/

@sergiocazzolato
Copy link
Collaborator

Also tried by using the latest cpu family on gce and the tests are getting stuck as well

@anonymouse64 anonymouse64 force-pushed the bugfix/temp-use-beta-core20-for-uc20-spread branch from b07c0cd to 4ce4eb6 Compare September 1, 2021 16:25
This works around a current bug in the core20 snap that causes UC20
specifically in GCE to fail to finish install mode / run mode because
snapd-seeding.service doesn't run/finish properly.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64
Copy link
Member Author

There was one errant failure to prepare here where the system didn't come back after a reboot, but I don't think that is related to this, I think we have an existing issue where that happens semi-randomly, but the fact that we still had many UC20 tests run successfully is a sign that this PR is working. I am going to retry though just to be sure that it works multiple times.

@anonymouse64
Copy link
Member Author

The core20 snap on edge is now updated to not break us so this branch is not necessary, however I would still like to change some things here, but I will propose that separately.

@anonymouse64 anonymouse64 deleted the bugfix/temp-use-beta-core20-for-uc20-spread branch September 1, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
5 participants