New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/lib/prepare.sh: use core20 from beta channel temporarily #10708
tests/lib/prepare.sh: use core20 from beta channel temporarily #10708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
Codecov Report
@@ Coverage Diff @@
## master #10708 +/- ##
==========================================
- Coverage 78.36% 78.35% -0.01%
==========================================
Files 884 884
Lines 99517 99517
==========================================
- Hits 77985 77977 -8
- Misses 16635 16640 +5
- Partials 4897 4900 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hmm uc20 is still failing though we at least can shell into the system now after it reboots 🤔 I will leave this to someone in EU to debug tomorrow morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is strange, I cannot reproduce the issue with qemu, core20 edge seems to be fine here. There was a new edge snap yesterday with https://people.canonical.com/~mvo/core20-changes/html/edge/'20210826'r1090_'20210831'r1097.html so it could be related to this but it's strange that we only see it in google. |
I see the core20 is in channel latest/edge, I think there was a refresh root@sep011136-995955:~# snap list |
This is the journal log and snap changes: |
Also tried by using the latest cpu family on gce and the tests are getting stuck as well |
b07c0cd
to
4ce4eb6
Compare
This works around a current bug in the core20 snap that causes UC20 specifically in GCE to fail to finish install mode / run mode because snapd-seeding.service doesn't run/finish properly. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
4ce4eb6
to
b1593e9
Compare
There was one errant failure to prepare here where the system didn't come back after a reboot, but I don't think that is related to this, I think we have an existing issue where that happens semi-randomly, but the fact that we still had many UC20 tests run successfully is a sign that this PR is working. I am going to retry though just to be sure that it works multiple times. |
The core20 snap on edge is now updated to not break us so this branch is not necessary, however I would still like to change some things here, but I will propose that separately. |
The core20 snap on edge currently makes all GCE spread runs fail somehow.