tests/nested/manual/refresh-revert-fundamentals: fix variable use #10722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit a7657b5 seems to have broken the test, which went unnoticed until there happened to be leaking a set -u from one of the sourced files which triggered this error: ``` + echo 'Check the new version of the snaps is correct after the system reboot' Check the new version of the snaps is correct after the system reboot + tests.nested exec 'snap list core20' + MATCH '^core20.*1113.*latest/edge.*' Warning: Permanently added '[localhost]:8022' (ECDSA) to the list of known hosts. + echo 'Check the change is completed' Check the change is completed + case "$SNAP" in /bin/bash: line 121: REVERT_ID: unbound variable ----- ``` Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
added
Simple 😃
Codecov Report
@@ Coverage Diff @@
## master #10722 +/- ##
==========================================
- Coverage 78.36% 78.35% -0.01%
==========================================
Files 885 885
Lines 99526 99526
==========================================
- Hits 77991 77987 -4
- Misses 16636 16639 +3
- Partials 4899 4900 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Trying to pass the right arguments to the retry tool on the nested host the quoting gets really complicated. Revert to invoking retry from the test host. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
|
Failures are unrelated, @mvo5 can you land this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a7657b5 seems to have broken the test,
which went unnoticed until there happened to be leaking a set -u from one of the
sourced files which triggered this error:
Signed-off-by: Maciej Borzecki maciej.zenon.borzecki@canonical.com
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?