asserts, snapstate: return full validation set keys from CheckPresenceRequired and CheckPresenceInvalid #10774
Conversation
stolowski
added
Needs Samuele review
Codecov Report
@@ Coverage Diff @@
## master #10774 +/- ##
==========================================
- Coverage 78.33% 78.32% -0.02%
==========================================
Files 890 890
Lines 100198 100205 +7
==========================================
- Hits 78488 78483 -5
- Misses 16792 16804 +12
Partials 4918 4918
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
No, I didn't forget about them but as with most internal errors, they would be hard/impossible to test because they could only occur if we had a bug somewhere and our structs were not consistent, we usually don't test such cases. |
| if vs == nil { | ||
| return nil, unspecifiedRevision, fmt.Errorf("internal error: no validation set for %q", rc.validationSetKey) | ||
| } | ||
| keys = append(keys, strings.Join(vs.At().PrimaryKey, "/")) |
There was a problem hiding this comment.
s/At/Ref/ works as well and is more typical for this use case
| if vs == nil { | ||
| return nil, fmt.Errorf("internal error: no validation set for %q", rc.validationSetKey) | ||
| } | ||
| keys = append(keys, strings.Join(vs.At().PrimaryKey, "/")) |
stolowski
force-pushed
the
validation-sets/fix-vset-keys
branch
2 times, most recently
from
0793b96
to
1332ada
Compare
CheckPresenceInvalid; full keys including series and sequence are expected by store api.
stolowski
force-pushed
the
validation-sets/fix-vset-keys
branch
from
1332ada
to
37e4b21
Compare
Return full validation set keys from CheckPresenceRequired and CheckPresenceInvalid. Full keys including series and sequence are expected by store api.