Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/nested/manual/core20-remodel: wait for device to have a serial before starting a remodel #11131

Merged
merged 3 commits into from Dec 6, 2021

Conversation

bboozzoo
Copy link
Collaborator

@bboozzoo bboozzoo commented Dec 1, 2021

Devices are expected to have serials before remodel can be started. We already have the right checks for tests/core, but not for nested tests.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
…before starting to remodel

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
@bboozzoo bboozzoo added Simple 😃 A small PR which can be reviewed quickly Run nested The PR also runs tests inluded in nested suite labels Dec 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #11131 (116fa26) into master (47873f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11131   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files         917      917           
  Lines      103960   103960           
=======================================
  Hits        81333    81333           
+ Misses      17531    17530    -1     
- Partials     5096     5097    +1     
Flag Coverage Δ
unittests 78.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
store/cache.go 69.23% <0.00%> (-1.93%) ⬇️
cmd/snap/cmd_debug_state.go 70.18% <0.00%> (-0.46%) ⬇️
overlord/snapstate/snapstate.go 82.88% <0.00%> (-0.13%) ⬇️
overlord/ifacestate/helpers.go 77.45% <0.00%> (+0.48%) ⬆️
daemon/api_connections.go 93.58% <0.00%> (+0.53%) ⬆️
interfaces/sorting.go 100.00% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47873f2...116fa26. Read the comment docs.

Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I wonder if there's some reason why you are not simply using the retry command.

@bboozzoo
Copy link
Collaborator Author

bboozzoo commented Dec 6, 2021

@mvo5 this is ready to land, can you merge?

@mvo5 mvo5 merged commit 49d5548 into snapcore:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run nested The PR also runs tests inluded in nested suite Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
5 participants